Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Add git-secrets --scan on Travis to detect unencrypted private key. #3315

Closed
blueandgold opened this issue Oct 15, 2019 · 3 comments
Closed
Labels
0 - Backlog Issue to be considered at some point in the future module: infrastructure priority: p2 Important feature defect, moderate live issue stale Stale items closed by Stale Bot triaged: yes

Comments

@blueandgold
Copy link
Contributor

blueandgold commented Oct 15, 2019

We install git-secrets in our local environments to prevent someone from committing private keys in the local repo. But we should also have a check on Travis (--scan option), in case this gets past the local check (i.e. if someone did not install or correctly configure git-secrets).

@blueandgold blueandgold added 0 - Backlog Issue to be considered at some point in the future priority: p2 Important feature defect, moderate live issue module: infrastructure triaged: yes labels Oct 15, 2019
@dekuhn dekuhn added this to the v2.25.0 milestone Oct 18, 2019
@gkowalski-google gkowalski-google modified the milestones: v2.25.0, v2.24.0 Oct 22, 2019
@red2k18 red2k18 modified the milestones: v2.24.0, v2.25.0 Nov 4, 2019
@gkowalski-google gkowalski-google modified the milestones: v2.25.0, v2.26.0 Nov 5, 2019
@dekuhn
Copy link
Contributor

dekuhn commented Nov 26, 2019

Will keep this in 2.25 release. The 2.25 sprint is being extended by 2 weeks

@red2k18 red2k18 added the 3 - Work in progress Issue is assigned to engineer and is actively working on the issue for targeted milestone release label Dec 2, 2019
@gkowalski-google gkowalski-google removed this from the v2.25.0 milestone Dec 9, 2019
@gkowalski-google gkowalski-google added this to the v2.26.0 milestone Jan 7, 2020
@gkowalski-google gkowalski-google removed this from the v2.26.0 milestone Feb 6, 2020
@gkowalski-google
Copy link
Collaborator

Re-open PR#3553. Only change should be to remove the last 4 lines so that the git-secret exit code will fail the build if a secret is found. Show a failed test build with a fake secret to show this is working.

@gkowalski-google gkowalski-google removed the 3 - Work in progress Issue is assigned to engineer and is actively working on the issue for targeted milestone release label Mar 9, 2020
@gkowalski-google gkowalski-google removed this from the Forseti Sprint 2020.04.27 milestone Apr 6, 2020
@stale
Copy link

stale bot commented May 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale items closed by Stale Bot label May 22, 2020
@stale stale bot closed this as completed Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0 - Backlog Issue to be considered at some point in the future module: infrastructure priority: p2 Important feature defect, moderate live issue stale Stale items closed by Stale Bot triaged: yes
Projects
None yet
Development

No branches or pull requests

4 participants