Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use nixpkgs-unstable flake input for nix-bitcoin pkgs #675

Merged
merged 1 commit into from Jan 16, 2024

Conversation

erikarvstedt
Copy link
Collaborator

@erikarvstedt erikarvstedt commented Jan 15, 2024

Copy of commit msg

By using the default flake module for tests, pkgsUnstable in pkgs/default.nix gets passed the nixpkgs-unstable flake input instead of falling back to importing nixpkgsPinned.nixpkgs-unstable.

For some use cases this prevents importing nixpkgs-unstable twice (once via the nixpkgs-unstable flake input, once via import nixpkgsPinned.nixpkgs-unstable).

By using the `default` flake module for tests, `pkgsUnstable` in
`pkgs/default.nix` gets passed the `nixpkgs-unstable` flake input
instead of falling back to importing `nixpkgsPinned.nixpkgs-unstable`.

For some use cases this prevents importing `nixpkgs-unstable` twice
(once via the `nixpkgs-unstable` flake input, once via
`import nixpkgsPinned.nixpkgs-unstable`).
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK afbd8a3

@jonasnick jonasnick merged commit 6f72575 into fort-nix:master Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants