Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider specifying links = "mbedcrypto" instead of "mbedtls" #289

Open
egrimley-arm opened this issue Jun 29, 2023 · 0 comments
Open

Consider specifying links = "mbedcrypto" instead of "mbedtls" #289

egrimley-arm opened this issue Jun 29, 2023 · 0 comments

Comments

@egrimley-arm
Copy link

The mbedtls-sys-auto crate specifies links = "mbedtls" (https://github.com/fortanix/rust-mbedtls/blob/master/mbedtls-sys/Cargo.toml#L14). In fact it links against three C libraries: libmbedcrypto.a, libmbedtls.a, libmbedx509.a.

There is another publicly available Rust crate, psa-crypto-sys, that links against libmbedcrypto.a only. That crate specifies links = "mbedcrypto" (https://github.com/parallaxsecond/rust-psa-crypto/blob/main/psa-crypto-sys/Cargo.toml#L12).

Perhaps it would be better for mbedtls-sys-auto to specify links = "mbedcrypto" so that the collision with psa-crypto-sys is detected by Cargo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant