Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Hangs on Exit (not Home button, the in-app exit button) #93

Closed
vgmoose opened this issue Nov 14, 2022 · 2 comments
Closed

[Switch] Hangs on Exit (not Home button, the in-app exit button) #93

vgmoose opened this issue Nov 14, 2022 · 2 comments
Labels
2.3-fixed Issues with this tag have been fixed on the main branch and will make it into the 2.3 release
Milestone
2.3 Release

Comments

@vgmoose
Copy link
Member

vgmoose commented Nov 14, 2022

The Switch build's exit button recently stopped working in both Applet and Title override modes. As far as I can tell, the app is cleaning up all its resources, however.

When trying to debug this by removing code until it doesn't occur, it seems to have something to do with networking. As soon as I talk to the HTTPS repo, the app no longer quits. This is further supported by using the NETWORK_MOCK build flag not showing the same behavior, or even testing with an HTTP repo and observing that it exits normally.

As annoying as it is, it's not really a blocker for an upcoming release, as the user can always exit using Home, and the button could be removed. But I've spent an unfortunate amount of time trying to debug this issue. Maybe trying to reproduce it in an emulator could be useful.
@vgmoose vgmoose added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 14, 2022
@vgmoose vgmoose mentioned this issue Nov 14, 2022
Closed
@vgmoose vgmoose added this to the 2.3 Release milestone Nov 14, 2022
@vgmoose
Copy link
Member Author

vgmoose commented Jan 5, 2023

It's anticlimactic, but this seems to have been addressed by just updating toolchain libraries.

@vgmoose vgmoose added 2.3-fixed Issues with this tag have been fixed on the main branch and will make it into the 2.3 release and removed help wanted Extra attention is needed good first issue Good for newcomers labels Jan 5, 2023
@vgmoose
Copy link
Member Author

vgmoose commented Mar 22, 2023

Fixed in 2.3.1

@vgmoose vgmoose closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.3-fixed Issues with this tag have been fixed on the main branch and will make it into the 2.3 release
Projects
None yet
Milestone
2.3 Release
Development

No branches or pull requests
1 participant
@vgmoose