Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity tests failing in fortinet.fortimanager #44

Open
dmsimard opened this issue May 2, 2022 · 3 comments
Open

Sanity tests failing in fortinet.fortimanager #44

dmsimard opened this issue May 2, 2022 · 3 comments

Comments

@dmsimard
Copy link

dmsimard commented May 2, 2022

Greetings from the Ansible community working group,

The fortinet.fortimanager collection is included in the Ansible community package (ansible on PyPI) and as such is expected to have CI which runs and passes sanity tests (amongst other things) as per documented here: https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#ci-testing

When running ansible-test sanity --docker on the latest version of the collection (2.1.5), we found that it took over fourty (40) hours to complete (recorded here), largely due to pylint getting stuck or struggling to go through the collection. In comparison, running sanity tests on 2.1.4 completed in ~7m15s.

We have not been able to find why pylint takes so long in 2.1.5 and leave it up to the maintainers to troubleshoot.

For the time being, we are considering temporarily reverting the version included in ansible back to 2.1.4.

If the collection is not improved to meet the collection inclusion specifications in the near future, it may also be at risk of being removed from the community package.

Please acknowledge the issue and keep us updated. Thank you.

@gundalow
Copy link

gundalow commented May 3, 2022

Although not ideal, running ansible-test sanity with --skip-test pylint would be an improvement over what we have today.

@dmsimard dmsimard changed the title Important, action needed: ansible-test sanity failures in latest version (2.1.5) Sanity tests failing in fortinet.fortimanager May 6, 2022
@dmsimard
Copy link
Author

dmsimard commented May 6, 2022

Linking this issue to the community topic on sanity tests: ansible-community/community-topics#96

The list of sanity test errors for this collection is available here: https://gist.githubusercontent.com/dmsimard/14e04158302003216a0bd7edfe2db110/raw/5774e739395c20fdffd63b98f33540eae043ded3/output.txt

@dmsimard
Copy link
Author

@JieX19 would it be possible to address the sanity test failures soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants