Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heartbeat calculation improvement based on heartbeat request sequence and timestamp #84

Closed
JaydenLiang opened this issue Sep 22, 2021 · 0 comments · Fixed by #89 or #95
Closed
Labels
tracked internal issue that is tracked in an internal system

Comments

@JaydenLiang
Copy link
Contributor

internal issue id: 0741713

It will make use of the two new properties in the incoming heartbeat request sending from FOS (at earliest 7.0.2)

Example request body:
{"instance": "i-0bd8fd4d2a36a841f", "interval": 30, "sequence":968, "time":"2021-08-19T04:40:38Z"}

use the new properties to determine heartbeat sequence and timing in order to keep or discard a certain heartbeat request.

the change should be compatible with existing FOS versions (7.0.1 and older) which send the heartbeat request in the format:
{"instance": "i-0bd8fd4d2a36a841f", "interval": 30}

code should not break without the presence of the new properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked internal issue that is tracked in an internal system
Projects
No open projects
1 participant