Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect distribution modules in stdlib_stats_distribution #544

Closed
awvwgk opened this issue Oct 3, 2021 · 3 comments · Fixed by #545
Closed

Collect distribution modules in stdlib_stats_distribution #544

awvwgk opened this issue Oct 3, 2021 · 3 comments · Fixed by #545
Labels
refactoring Internal change for better maintainablility topic: statistics Statistical functions
Milestone

Comments

@awvwgk
Copy link
Member

awvwgk commented Oct 3, 2021

@Jim-215-Fisher in #538 (comment)

Regarding to stdlib_stats_distribution_PRNG module, I am not sure whether it should be in stats_distribution package. GSL has a separate random numbers package in addition to random distributions and statistics.

Should stdlib_stats_distribution_PRNG become a submodule of stdlib_stats_distribution?

@awvwgk awvwgk added topic: statistics Statistical functions refactoring Internal change for better maintainablility labels Oct 3, 2021
@awvwgk awvwgk changed the title Collect statistics modules in stats_distribution Collect distribution modules in stdlib_stats_distribution Oct 3, 2021
@milancurcic
Copy link
Member

I think it should be in the stdlib_random module.

@jvdp1
Copy link
Member

jvdp1 commented Oct 3, 2021

I though a bit about yesterday while reviewing #272. However, there are other PRs proposing similar functions. Therefore I decided to review first these other PRs, before taking a decision ;) I am a bit puzzled because these modules provide procedures related to the distributions (pdf, cdf) and to randomness (rnd). I wonder if it would not be better to generate 2 different modules (distribution vs random)

@Jim-215-Fisher
Copy link
Contributor

I think PRNG should be in a separate random module as GSL does. PRNG generates random integer numbers with defined kind which could be used for applications way beyond of random distributions. Furthermore, PRNG may contain parallel version of generators in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal change for better maintainablility topic: statistics Statistical functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants