Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fpm build in README for faster getting started #734

Closed
jalvesz opened this issue Aug 29, 2023 · 1 comment
Closed

Improve fpm build in README for faster getting started #734

jalvesz opened this issue Aug 29, 2023 · 1 comment

Comments

@jalvesz
Copy link
Contributor

jalvesz commented Aug 29, 2023

Hello,

I wanted to make a suggestion regarding the README instructions for building with fpm that might seem evident but I felt that could have avoided me some head scratching.

After forking and downloading the branch locally, the 'git checkout stdlib-fpm' command did not work directly, so I had to do the following which seems a bit more explicit:
source ./ci/fpm-deployment.sh
cd stdlib-fpm/

I would suggest adding these two lines to the readme but I wanted to ask if there is any reason not to?

(side question: would it be worth it to have a companion fpm-deployment.bat for windows?)

@jvdp1
Copy link
Member

jvdp1 commented Dec 25, 2023

Sorry for the late reply.

After forking and downloading the branch locally, the 'git checkout stdlib-fpm' command did not work directly, so I had to do the following which seems a bit more explicit: source ./ci/fpm-deployment.sh cd stdlib-fpm/

I would suggest adding these two lines to the readme but I wanted to ask if there is any reason not to?

No, there is nor reason to not mention it. Ideally fpm should support fypp. But meanwhile I support your idea. Would you like to open a PR with your suggestion?

(side question: would it be worth it to have a companion fpm-deployment.bat for windows?)

I am not familiar with Windows. However, if it helpfuls, please propose such a script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants