Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to babel.config.json #361

Closed
kmonahan opened this issue May 7, 2020 · 0 comments · Fixed by #364
Closed

Consider switching to babel.config.json #361

kmonahan opened this issue May 7, 2020 · 0 comments · Fixed by #364

Comments

@kmonahan
Copy link
Collaborator

kmonahan commented May 7, 2020

Currently, Gesso includes a .babelrc file for Babel configuration. As of Babel 7, project-level configuration should be in babel.config.json instead, as .babelrc won't be applied to node_modules. (See https://babeljs.io/docs/en/configuration and babel/babel-loader#171 (comment) for reference.) Most of the time, this doesn't make any difference, since node_modules are excluded from the babel_loader in the webpack config anyway. However, some modules (e.g. https://swiperjs.com/get-started/) can be imported as ES6 modules and require transpiling for IE11. Switching to babel.config.json would allow a dev to whitelist modules as needed in the webpack config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant