Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix nested clickable event propagation & misc. code cleanup #10

Merged
merged 5 commits into from
May 16, 2022

Conversation

filipboev
Copy link
Collaborator

@filipboev filipboev commented Apr 26, 2022

  • Fix vulnerabilities
  • Clean up code & set some linting rules
  • Fix outstanding bug for nested interactable elements (clickable/touchable)]

We don't expect nested anchor tags since those are illegal anyway, but if there are any nested touchables, this should handle them, since they are almost always handled separately as an event which prevents their default behaviour.

@filipboev filipboev changed the title Chore: Polish up code chore: Polish up code Apr 26, 2022
@filipboev filipboev changed the title chore: Polish up code fix: Fix nested clickable event propagation & misc. code cleanup May 10, 2022
@filipboev filipboev merged commit c1675a8 into master May 16, 2022
@filipboev filipboev deleted the chore/polish-up-code branch May 16, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant