Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumes only one ELB per instance #63

Open
edhgoose opened this issue Feb 18, 2015 · 0 comments · May be fixed by #64
Open

Assumes only one ELB per instance #63

edhgoose opened this issue Feb 18, 2015 · 0 comments · May be fixed by #64

Comments

@edhgoose
Copy link

Hiya,

We have an environment where individual instances are running multiple servers behind multiple load balancers (mostly for cost saving).

I think Capify-ec2 assumes that each instance only belongs to one load balancer.

For instance:
We have two environments, dev and staging. They both run on the same instance. This instance has two load balancers, one for dev and one for staging, pointing to different ports with different health checks.

During a deployment of staging the degreister_instance_from_elb_by_dns de-registered the instance from the dev ELB.

I have a couple of ideas on solutions, but imagine it could get pretty complicated pretty quick.

  • The simplest would be to deregister from all ELBs, but that isn't quite right.
  • An alternative would be to accept another parameter alongside :load_balanced which provides a regex or name of the ELB that can be deregistered from.
  • A final idea would be to reuse the health check: i.e. get all ELBs that this instance is part of, and using the health checks from each role deregister it if there is a match between the ELB list and the health check list.

Let me know your thoughts - I'll see if I can prototype something when I get some time.

Cheers,
Ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant