Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xBuild multistatus handles empty responses incorrectly #8

Closed
HeikoTheissen opened this issue Dec 21, 2020 · 0 comments · Fixed by #9
Closed

xBuild multistatus handles empty responses incorrectly #8

HeikoTheissen opened this issue Dec 21, 2020 · 0 comments · Fixed by #9

Comments

@HeikoTheissen
Copy link

https://github.com/sedenardi/node-caldav-adapter/blob/62a34c2c9204db37f789d08c378318127cb4090d/src/common/xBuild.ts#L29

If responses.length === 0, then res is constructed from the previous nsMap, so the <multistatus>element from previous response is returned again. Correct would be to return an empty <multistatus> element in that case.
This was referenced Dec 22, 2020
Closed
Merged
@sedenardi sedenardi linked a pull request Dec 29, 2020 that will close this issue
Fix davx5 missing e-tag error. #9
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix davx5 missing e-tag error. aharter/node-caldav-adapter
1 participant
@HeikoTheissen