Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing typescript definitions #367

Closed
simllll opened this issue Jun 24, 2019 · 5 comments
Closed

missing typescript definitions #367

simllll opened this issue Jun 24, 2019 · 5 comments

Comments

@simllll
Copy link

simllll commented Jun 24, 2019

There is @types/email-templates, but it' really outdated and incomplete. Would be great if this project will add typescript definitions bundled with it.

Furthermore I would like to add some variable wordings which kinda confused me:

  • locals .. is actually the data that is passed to the template
  • template .. is the folder where the templates are in
  • type .. is the name of the template

Regards
Simon

@niftylettuce
Copy link
Collaborator

I do not support TypeScript. It is bad for the community and open-source.

@simllll
Copy link
Author

simllll commented Jun 24, 2019

Alright,no worries. Just our of curiosity, why do you think it's bad for the community and for the open source world? What do you think about flow or other alternatives?

@niftylettuce
Copy link
Collaborator

The barrier to entry for someone contributing to open source and opening a pull request is already high. If you add on another layer of complexity, e.g. TypeScript, CoffeeScript, WhateverScript, then it only makes it harder. I also do not think TypeScript is necessary for such simple projects and packages. The only "compiler" I support across the entire community is Babel, and that is because it allows us to compile towards browser versions and Node version targets in order for us to support a range of projects and lint them as well.

@maplesteve
Copy link

@niftylettuce I think this is not about migrating this project to TypeScript, but just to make it more usable for people who use it in projects written in TypeScript.

@niftylettuce
Copy link
Collaborator

I don't support TypeScript in any case across any of my projects on GitHub, regardless if it's to help make it more usable for others or not. TypeScript is overkill, bloat, and not community-friendly nor maintainer-friendly.

After managing and contributing to thousands of packages for nearly a decade now - I refuse to use or support anything but pure JS.

@forwardemail forwardemail locked as resolved and limited conversation to collaborators Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants