Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate.js dependency is not up to date on npm, cannot render twing. Fix here. #405

Closed
ghost opened this issue Sep 8, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 8, 2020

Looks like consolidate.js hasn't been updated on npm for years, so lots of template engines are missing.
To get the latest version ....

npm install tj/consolidate.js#master
cd node_modules/email-templates
npm install tj/consolidate.js#master

I had to find a different template engine, I thought it was just me who instantly hated everything about pug!
https://www.quora.com/Do-web-developers-use-tools-like-Jade-Pug-rather-than-code-in-raw-HTML/answer/Frank-M-Taylor-1
"I hate Jade/Pug with the passion of a thousand burning suns" - I know how he feels!

I love this email-templates package, but might I suggest anything but pug for newbies?
If they want the sado-masochistic coding equivalent of nails on a blackboard, then offer pug as an option, but for newbies at least offer something friendly :)

@niftylettuce
Copy link
Collaborator

Also someone leaving a post on Quora, stating they have a certificate in programming and front-end development, and one from an online campus does not warrant it to be an expert opinion. I'm releasing a new version of email-templates with this bumped in just a moment.

@shaunwarman
Copy link
Contributor

Out of curiosity is there a template engine you would prefer as an option? @digitaltoast

@niftylettuce
Copy link
Collaborator

v7.1.1 released to npm, thank you https://github.com/forwardemail/email-templates/releases/tag/v7.1.1

@ghost
Copy link
Author

ghost commented Sep 8, 2020

I just merged a few PR's and bumped consolidate to v0.16.0 @ https://github.com/tj/consolidate.js/releases/tag/v0.16.0.

@niftylettuce Wow - I just realised that you actually do ALL these projects! I feel bad for being critical now as you are ridiculously productive in open source; thank you so much for these releases.

But I still really struggle with Pug - so many syntactical tripwires and a steep learning curve. Whereas, with Twig (Twing), it's the same old standard html we all understand, with clearly defined {{tags}}. #406 I really appreciate the work you've done to bring so many template engines on board which means whichever engine we prefer, we can use it. Thank you!

@forwardemail forwardemail deleted a comment from niftylettuce Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants