Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option open is incorrectly handled and/or documented #20

Closed
euvs opened this issue May 13, 2020 · 1 comment
Closed

Option open is incorrectly handled and/or documented #20

euvs opened this issue May 13, 2020 · 1 comment

Comments

@euvs
Copy link

euvs commented May 13, 2020

According to the readme, theopen option is supposed to be a Boolean or an object of the { wait: false } format. However in the code it only checks for boolean.

https://github.com/forwardemail/preview-email/blob/4e48c73756b13599bbff92e30fe20a9bf1dd54e5/src/index.js#L55

If { wait: false } is passed it will always be true
@niftylettuce
Copy link
Collaborator

PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftylettuce @euvs