Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News from the future #67

Closed
cimnine opened this issue Mar 15, 2013 · 5 comments
Closed

News from the future #67

cimnine opened this issue Mar 15, 2013 · 5 comments
Labels

Comments

@cimnine
Copy link
Contributor

cimnine commented Mar 15, 2013

Problem

I have some feeds which aren't very kind with their dates, i.e. they come with a date from the future. This results in news entries like " _title_ [tag] feedname • -1820758 seconds ago ".

Proposal

Don't allow dates after now(), and reset all dates after now() to now().

~Chris

@ghost
Copy link

ghost commented Mar 15, 2013

Isn't that more likely to be a timezone-issue? If not - I agree.

@cimnine
Copy link
Contributor Author

cimnine commented Mar 15, 2013

The time zone idea might be worth investigating, as all the feeds that
encounter this issue are currently feeds from Switzerland.
Nevertheless, if an article in a feed is from the future after converting
it to local time, it's time values should be corrected to now().

@SSilence
Copy link
Member

Can you give me a your feed url with entries in the future? There is still a check in ContentLoader which checks whether a date is in the future and sets it to now.

@cimnine
Copy link
Contributor Author

cimnine commented Mar 16, 2013

For example this one:
http://www1.orange.ch/de/residential/tv-cinema/events/feed/

With this one the
updated field is indeed from the future

@SSilence
Copy link
Member

Oh yes... embarrassing. I was checking the date and was setting it to the current date but was using the original date from the feed ;) I fixed the bug.

@jtojnar jtojnar added the bug label Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants