[WorldMoodTracker] Initialized World Mood Tracker app #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpratyush
changed the title
singhpratyush
force-pushed
the
world-mood-tracker-init
branch
2 times, most recently
from
0aa63cd
to
3fbdd00
Compare
singhpratyush
changed the title
|
@daminisatya @djmgit @kavithaenair: Please review. |
| @@ -1,7 +1,7 @@ | |||
| [default] | |||
| bears = LineLengthBear, SpaceConsistencyBear | |||
| files = **.js, **.css, **.html, **.yml, **.json | |||
| ignore = **.min.js, **.min.css, tweetheatmap/public/lib/**, webtweets/js/bootstrap/**, webtweets/css/bootstrap.css, js/typeahead.bundle.js, webtweets/js/bootstrap.js | |||
| ignore = **.min.js, **.min.css, tweetheatmap/public/lib/**, webtweets/js/bootstrap/**, webtweets/css/bootstrap.css, js/typeahead.bundle.js, webtweets/js/bootstrap.js, **/node_modules/**, **/index_bundle.js, WorldMoodTracker/index.html | |||
There was a problem hiding this comment.
index.html and js files written by you should not be ignored by coala bears i guess.
There was a problem hiding this comment.
It is not like that. The two files ignored are generated by webpack while the build process.
cd WorldMoodTracker
yarn install # If not already
yarn build| @@ -20,7 +20,7 @@ use_spaces = True | |||
| [js] | |||
| bears = PHPCodeSnifferBear | |||
| files = **.js | |||
| ignore = **.min.js, tweetheatmap/public/lib/**, /app/webtweets/js/bootstrap/** | |||
| ignore = **.min.js, tweetheatmap/public/lib/**, /app/webtweets/js/bootstrap/**, **/node_modules/**, **/index_bundle.js | |||
|
@Achint08 @hemantjadon: Please take a look. |
* Add Webpack, babel and related configurations * Ignore node_modules for sub apps * Add missing glyohicons font * Ignore dynamic files for coala
singhpratyush
force-pushed
the
world-mood-tracker-init
branch
from
3fbdd00
to
d9d76d4
Compare
daminisatya
approved these changes
Jun 16, 2017
|
Great to see this getting started! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Fixes #188.
Changes:
Screenshots for the change:
I have:
Fixes #<number> commit messageFor the reviewers
I have: