Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use envparse or other utility like in open-event instead of harcoded variables. #1810

Closed
1 of 2 tasks
rupav opened this issue Oct 16, 2018 · 4 comments · Fixed by #1839
Closed
1 of 2 tasks

use envparse or other utility like in open-event instead of harcoded variables. #1810

rupav opened this issue Oct 16, 2018 · 4 comments · Fixed by #1839

Comments

@rupav
Copy link
Member

rupav commented Oct 16, 2018

I'm submitting a ...

  • bug report
  • feature request

Current behaviour:

Currently before sending a PR, I have to switch back to ENV=PROD from LOCAL, making it hard for the development process. This can be cumbersome, if other variables are too set this way for my local setup, and needs to be reverted back to original for sending the PR.

Expected behaviour:

This can be avoided, if we use envparse to parse the environement variables. This way it will fetch the env variable that I have set locally on my PC, instead in the project. This is also a good practice as per one of the 12 principles of 12 factors app.

@yashLadha @gabru-md @ParthS007 your views on this?

I would like to work on this.

@rupav rupav changed the title use envparse or other utility like open-event instead of harcoded variables. use envparse or other utility like in open-event instead of harcoded variables. Oct 16, 2018
@championpaddler
Copy link
Member

@rupav It is a great idea we can also set verification email domain using this.

@ParthS007
Copy link
Member

@rupav Sound good to me. Please go ahead.

@gabru-md
Copy link
Member

@rupav the issue is a certain solid one. You can proceed with it and create a PR
cheers!

@ParthS007
Copy link
Member

@rupav Please update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants