Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons and Title #77

Closed
5 tasks done
niccokunzmann opened this issue Feb 8, 2016 · 5 comments
Closed
5 tasks done

Icons and Title #77

niccokunzmann opened this issue Feb 8, 2016 · 5 comments

Comments

@niccokunzmann
Copy link
Member

  • Add a title to the index.html file
  • Add the favicon.ico to the credits.html page
  • Add a favicon.ico to the links.html page
  • The titles should have a similar structure in credits.html, links.html and flappy.html
  • The most informing part of the title should be in the first 8 characters

Comment if you would like to work in this issue. We can do several pull-requests for this one.

@SilentFlame
Copy link
Contributor

@niccokunzmann
how about the following:

  • Flappy-SVG Game as the title for index.html
  • what exactly for favicon.ico needed, and what exactly it does?
  • titles consistent across where?

@shubheksha
Copy link
Contributor

Hey! I'd like to work on this issue. Should I submit a single PR for all the specified changes?
Also, is there something specific that needs to be used as the title?

@oanarosca
Copy link
Member

Hello! I did a little work on this, I hope it helps a bit :)

@niccokunzmann
Copy link
Member Author

Hi everyone! Welcome in board! In general: You can submit several pull-requests for one issue and we will discuss them :)

To me it seems like @oanarosca already solved the issue.
@shubheksha I accidentally merged too fast. If you like, you can still review the merge and tell me whether is issue can be closed and everything is to your satisfaction.

You are welcome to create issues for your own ideas that you would like in the game. E.g. if you see a bug or if you think that something is not perfect and should be improved. We also have a tasks section where you can choose from other ways to contribute. Issues are for things that can be done only once but the tasks, like adding a character, can be done by several people.

@niccokunzmann
Copy link
Member Author

Thanks for contributing! I am closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants