New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressing images for better performance #712
Comments
I am ok with it, if the community is ok i would like to work on this, this is how I plan to go ahead: |
@Abhi2424shek -- just add the check -- keep the structure I have set up |
Fail it if it's not optimized...I'd rather not push changes like that. Give students pointers in how to opitmize the images themselves. |
@robbyoconnor ok sir then we will not push changes back! |
@Abhi2424shek @robbyoconnor @Elgayar We can use Shrinkray.io |
@ankitrgadiya @robbyoconnor @Elgayar what should be the maximum image size shall we fix it as 1mb. |
@Abhi2424shek Are you talking about 1mb for all images or 1mb/picture? |
The images are already maximum 200 KB, so you're giving more than double what they need. |
@Elgayar 150kb is alot. All pictures in Students and Mentors section should be no more than 20kb, which most of them already are. And about Blog section the images should not be more than 50kb. First image in low quality compared to second one. But guess what first one is around 32kb and second one is just 14kb. We have to do things like this. |
@ankitrgadiya @Elgayar then we will fix the cap at 100 kb for student's mentor's and project's images and a 200 kb for blog images... |
Hey someone already did this using shrinkray.io and are pushing back... So can we close this then I think it's @gaeun who did it anyways good work. |
The website is painfully slow as mentioned in issue #632 by @robbyoconnor
I opened this issue in order to discuss methods of compressing images on the website (preferably lossless compression).
I came across that API: https://imageoptim.com/api/start
Can you guys please take a look and say your opinion about it and if I should try using it?
The text was updated successfully, but these errors were encountered: