fix: back funtionality of the app #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the issue was in onBackPresses in main activity if the rootFragment is other than EventFragment it will assume that it is Main page which will be wrong in all other cases like TicketFragment, AttendeeFragment, OrderDetailsFragment, it was calling EventFragment finish method which was closing our app , so add conditions for these Fragments too. issue:fossasia#726
pranavpandey1998official
changed the title
pranavpandey1998official
changed the title
liveHarshit
reviewed
Jan 2, 2019
app/src/main/java/org/fossasia/openevent/general/MainActivity.kt
Outdated
Show resolved
Hide resolved
liveHarshit
reviewed
Jan 2, 2019
| is TicketsFragment, | ||
| is AttendeeFragment, | ||
| is OrderDetailsFragment -> super.onBackPressed() | ||
| else -> when (currentFragment) { |
There was a problem hiding this comment.
Both when conditions can be written separately. Let mentors review it.
There was a problem hiding this comment.
This is massive duplication
There was a problem hiding this comment.
@iamareebjamal how about this the rootFragment is null when we are in the main page so
if (rootFragment == null) {
when (currentFragment) {
is SearchFragment,
is FavoriteFragment,
is OrdersUnderUserFragment,
is ProfileFragment -> {
loadFragment(supportFragmentManager, EventsFragment(), frameContainer.id)
navigation.selectedItemId = navigation_events
}
is EventsFragment -> finish()
else -> super.onBackPressed()
}
}
else super.onBackPressed()
There was a problem hiding this comment.
Seems better but reverse the condition and use early return
There was a problem hiding this comment.
@iamareebjamal like this
if (rootFragment != null) {
super.onBackPressed()
return
}
when (currentFragment) {
is SearchFragment,
is FavoriteFragment,
is OrdersUnderUserFragment,
is ProfileFragment -> {
loadFragment(supportFragmentManager, EventsFragment(), frameContainer.id)
navigation.selectedItemId = navigation_events
}
is EventsFragment -> finish()
else -> super.onBackPressed()
}
}
|
@pranavpandey1998official This issue is solved in PR #823 with navigation. Sorry for it. onBackPressed method is not required anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726
the issue was in onBackPresses in main activity if the rootFragment is other than EventFragment it will assume that it is Main page which will be wrong in all other cases like TicketFragment, AttendeeFragment, OrderDetailsFragment, it was calling EventFragment finish method which was closing our app , so add conditions for these Fragments too.