Footer section recommendations

[thanostx]

Is your feature request related to a problem? Please describe.

No. There are mostly enhancements.

Describe the solution you'd like

Some of the content on footer is hardcoded on the templates and doesn't provide any context in a on-premise deployment. My proposals are:

1. Use settings.appName variable to replace "eventyay" text.
   https://github.com/fossasia/open-event-frontend/blob/development/app/templates/components/footer-main.hbs#L5

2. Hide or drop the content of "Nearby Events" section as the URLs don't point to any page/section [1]. A more sophisticated solution here, would be to create a dynamic list based on the event locations [2].

[1] https://github.com/fossasia/open-event-frontend/blob/development/app/templates/components/footer-main.hbs#L25
[2] https://open-event-api-dev.herokuapp.com/#event-locations

3. Hide "Connect with us" section by default and show it only when the user adds a link.

[shreyanshdwivedi]

@thanostx can I work on this?

[thanostx]

@shreyanshdwivedi I'm not sure if I'm "authorized" to give you an approval.
But if you ask me, I didn't start working on it, so please feel free to take it.

I assume maintainers will have the last call if this enhancement worth a merge.

[abhinavk96]

@thanostx Thanks for reporting this issue :)
@Anupam-dagar @shreyanshdwivedi Please proceed.

[shreyanshdwivedi]

@CosmicCoder96 I guess u wanted to tag me 😅

[abhinavk96]

yeah, sorry @shreyanshdwivedi go ahead 😄

[Parth910]

@shreyanshdwivedi, if you are not working on it then I would like to work on it. Are you working on this?

[shreyanshdwivedi]

@Parth910 I've already made changes on my local. Fixing a few things. I'll open a PR soon

[kushthedude]

@shreyanshdwivedi Since there is no WIP Pr opened , Can i proceed with this?

[kushthedude]

@shreyanshdwivedi ??

[kushthedude]

Working on it.

[kushthedude]

@shreyanshdwivedi Can you please tell what the enhancement number second wants to state?

[shreyanshdwivedi]

@kushthedude Nearby Events don't show dynamic list of events. It is hard coded. This needs to be fixed

[thanostx]

Just for future reference, the second request duplicates this issue here #1823

[kushthedude]

@CosmicCoder96 regarding the dynamic ‘Nearby Events’ , as this needs user location and a constraint on number of events to be displayed on basis on distance . Should I push a PR with only two changes ? As the featured events and event location functionality , i am planning to do it in GSOC , Or should i wait untill location functionality is implemented ?

[maze-runnar]

@kushthedude , i am stuck a bit while working on it at one place, can you please help me with any reference that how to return current city using ember-cli-geo or geolocation .

[mariobehling]

Closing this as the design has been changed.