Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cancel and Delete order #3026

Merged
merged 3 commits into from
Jan 27, 2017

Conversation

shubham-padia
Copy link
Member

Resolves #2986 .
selection_096

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 75.454% when pulling 88b066c on shubham-padia:development into 2633ace on fossasia:development.

@codecov-io
Copy link

codecov-io commented Jan 24, 2017

Current coverage is 75.17% (diff: 17.07%)

Merging #3026 into development will decrease coverage by 0.26%

@@           development      #3026   diff @@
=============================================
  Files              220        220          
  Lines            14889      14930    +41   
  Methods              0          0          
  Messages             0          0          
  Branches             0          0          
=============================================
- Hits             11231      11223     -8   
- Misses            3658       3707    +49   
  Partials             0          0          

Powered by Codecov. Last update b9f7976...0bf86a9

Copy link
Member

@niranjan94 niranjan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham-padia if an already paid for order is cancelled/deleted, how are the refunds handled ?

@shubham-padia
Copy link
Member Author

shubham-padia commented Jan 24, 2017

@niranjan94

if an already paid for order is cancelled/deleted, how are the refunds handled ?

AFAIK we do not have the payment details of the user stored, so nothing for that for now. As an alternative removing/cancelling can be disabled for completed orders. What do you think?

@niranjan94
Copy link
Member

@shubham-padia actually, we do store the unique order reference ID from paypal/stripe for each payment. We can initiate refunds via Stripe/PayPal API.

@mariobehling do we need refund functionality or can cancel/delete option be disabled for paid orders. ?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4387813 on shubham-padia:development into ** on fossasia:development**.

@shubham-padia
Copy link
Member Author

do we need refund functionality or can cancel/delete option be disabled for paid orders. ?

@mariobehling suggestions on what should be done?

@mariobehling
Copy link
Member

@mariobehling do we need refund functionality or can cancel/delete option be disabled for paid orders.

For now, disable the delete functionality for these in the system.

@shubham-padia actually, we do store the unique order reference ID from paypal/stripe for each payment. We can initiate refunds via Stripe/PayPal API.

Yes, this is the way to go. Please open an issue, but tag it "later" until we have a more stable release. For now we can simply "cancel" paid tickets if required and tell the user to do the refund through paypal. We have so many areas to take care of and better follow up on this later, I would say.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 75.454% when pulling e77ec0f on shubham-padia:development into 55249a0 on fossasia:development.

@shubham-padia shubham-padia force-pushed the development branch 2 times, most recently from a8f763d to 4342c00 Compare January 26, 2017 07:11
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4342c00 on shubham-padia:development into ** on fossasia:development**.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.988% when pulling 03ebef7 on shubham-padia:development into b58f78f on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 74.988% when pulling 03ebef7 on shubham-padia:development into b58f78f on fossasia:development.

@shubham-padia shubham-padia force-pushed the development branch 2 times, most recently from 4919236 to 8b09c15 Compare January 26, 2017 09:12
@shubham-padia
Copy link
Member Author

@niranjan94 @mariobehling Please review. following are some screenshots:
If the ticket is paid and status is completed it cannot be deleted
1.)
selection_104

2.)
selection_101

3.)
selection_103

4.)
selection_099

5.)
selection_098

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.943% when pulling dcea3c0 on shubham-padia:development into b9f7976 on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.943% when pulling dcea3c0 on shubham-padia:development into b9f7976 on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.943% when pulling dcea3c0 on shubham-padia:development into b9f7976 on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.943% when pulling 97be717 on shubham-padia:development into b9f7976 on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.943% when pulling 97be717 on shubham-padia:development into b9f7976 on fossasia:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.943% when pulling 0bf86a9 on shubham-padia:development into b9f7976 on fossasia:development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants