-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Cancel and Delete order #3026
Conversation
627c639
to
88b066c
Compare
Current coverage is 75.17% (diff: 17.07%)
@@ development #3026 diff @@
=============================================
Files 220 220
Lines 14889 14930 +41
Methods 0 0
Messages 0 0
Branches 0 0
=============================================
- Hits 11231 11223 -8
- Misses 3658 3707 +49
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham-padia if an already paid for order is cancelled/deleted, how are the refunds handled ?
AFAIK we do not have the payment details of the user stored, so nothing for that for now. As an alternative removing/cancelling can be disabled for completed orders. What do you think? |
@shubham-padia actually, we do store the unique order reference ID from paypal/stripe for each payment. We can initiate refunds via Stripe/PayPal API. @mariobehling do we need refund functionality or can cancel/delete option be disabled for paid orders. ? |
Changes Unknown when pulling 4387813 on shubham-padia:development into ** on fossasia:development**. |
@mariobehling suggestions on what should be done? |
For now, disable the delete functionality for these in the system.
Yes, this is the way to go. Please open an issue, but tag it "later" until we have a more stable release. For now we can simply "cancel" paid tickets if required and tell the user to do the refund through paypal. We have so many areas to take care of and better follow up on this later, I would say. |
a8f763d
to
4342c00
Compare
Changes Unknown when pulling 4342c00 on shubham-padia:development into ** on fossasia:development**. |
4919236
to
8b09c15
Compare
@niranjan94 @mariobehling Please review. following are some screenshots: |
dcea3c0
to
6b92ecb
Compare
6b92ecb
to
97be717
Compare
Resolves #2986 .