Show number of sold and available tickets for each ticket type on the… #3075
Conversation
|
@Princu7 Thank you. Could you take out the progress bar, please? No need to progress bar. The progress bar does not need to be there. |
|
Please also check the travis build. Thank you. |
|
@mariobehling I have made the required changes and updated the screenshots. I will correct the build mistake. Thanks |
Codecov Report
@@ Coverage Diff @@
## development #3075 +/- ##
===============================================
- Coverage 76.11% 76.03% -0.08%
===============================================
Files 222 222
Lines 14806 14790 -16
===============================================
- Hits 11269 11246 -23
- Misses 3537 3544 +7
Continue to review full report at Codecov.
|
|
Changes Unknown when pulling bdff82d on Princu7:development into ** on fossasia:development**. |
| @@ -94,7 +94,7 @@ def get_invite_by_user_id(user_id): | |||
| @staticmethod | |||
| def get_all_events(): | |||
| """Method return all events""" | |||
| return Event.query.order_by(desc(Event.id)).filter_by(in_trash=False).all() | |||
| return Event.query.order_by(desc(Event.id)).filter_by().all() | |||
There was a problem hiding this comment.
Please explain this change.
There was a problem hiding this comment.
@SaptakS In the Super Admin event section, all_ticket_stats variable is supposed to store the information about the tickets of all the events including the trashed ones. Since the get_all_events() function didn't return the trashed events, the app crashed when an event was deleted in admin section. So I modified the definition of the function.
I looked at the code and there seems to be many places where this function is called. So modifying it wasn't a good idea. I will change it to its original definition and concat the all_events and trash_events when there is need for all the events including the trashed events. Thank you so much for pointing out the mistake :)
… specific event dashboard and the admin section Removed the progress bar
|
@SaptakS I have explained my mistake and corrected it. Please review it. Thanks.!! |
… specific event dashboard and the admin section. Fixes the issue #3039. Here are some screenshots:
Event section of User
Event section of Admin
Here is the test server deployed on Heroku
http://ancient-thicket-44821.herokuapp.com
Admin Credentials:
@niranjan94 @SaptakS @mariobehling Please review and suggest improvements. Thanks!!