-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cron job for marking event invoices due is wrong #6494
Labels
Comments
@iamareebjamal I would like to take this one if no one is working on it. |
Go ahead. This is high priority issue so please try to submit a PR within few days |
@iamareebjamal are there any tests written for scheduled jobs? |
For some of them, it might be written, I'm not sure |
@arpit551 If you're pre-occupied elsewhere, I'll go ahead & fix this. |
@mrsaicharan1 Please go ahead, this is high priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #6166 is wrong. The query fails in every case
open-event-server/app/api/helpers/scheduled_jobs.py
Lines 164 to 174 in bc45c1d
This line is not valid SQLAlchemy syntax:
open-event-server/app/api/helpers/scheduled_jobs.py
Line 169 in bc45c1d
Neither 'InstrumentedAttribute' object nor 'Comparator' object associated with EventInvoice.event has an attribute 'ends_at'
It should be
db.session.query(EventInvoice).join(Event).filter(EventInvoice.status == 'upcoming', Event.ends_at >= datetime.datetime.now()).all()
Each run of this task is failing
Fix it and write tests to ensure it is working
The text was updated successfully, but these errors were encountered: