-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wordpress Integration file with volley library #129
Conversation
Pls resolve the conflicts your fork seems to be behind. |
@deepakbansal168 @Abhi2424shek @pa1pal I am working on Authentication from - https://developer.wordpress.com/docs/oauth2/ |
Not saved to accounts database. Added Todo's.
I have done the OAuth part but needed some help regarding committing my changes to this PR. I tried sending a PR to |
Yes, to directly commit you would need wrote access, however you could also sent a PR to his development branch which if he accepts and merge would become a merge commit and be shown here like a regular commit. @harsu-ag |
@Abhi2424shek I was not able to send a PR to his development branch. As I have already forked the fossasia project, I was not able to fork a deepak's fork. |
# Conflicts: # app/build.gradle
Codecov Report
@@ Coverage Diff @@
## development #129 +/- ##
================================================
- Coverage 2.55% 2.54% -0.01%
Complexity 90 90
================================================
Files 303 307 +4
Lines 39095 39245 +150
Branches 4881 4892 +11
================================================
Hits 997 997
- Misses 38007 38157 +150
Partials 91 91
Continue to review full report at Codecov.
|
@harsu-ag i am still waiting for your update. |
@deepakbhansal seems like @harsu-ag is not near, can you work on it on your own please. This is a critical part of the app, would you be needing any help? |
@Abhi2424shek let me help out @deepakbansal168 with this. |
Sure have a try. |
@deepakbansal168 Thanks for your contribution. Please help to resolve the conflicts. |
sure i will resolve the conflicts. |
@rohanagarwal @deepakbansal168 is waiting for you, any inputs please, it would be awesome. |
@Abhi2424shek it needs a lot of changes to bring this feature to execution. It requires me maximum a day more to figure everything out before I create a PR. I would request to close this PR since this is not a native solution and is using webview. In fact this code is not even fetching the media of a particular wordpress website. I will send the PR as soon as possible. |
Please do work in collaboration with @deepakbansal168 @rohanagarwal :) It would be better if you two could communicate together and decide to who's fork the changes will be pushed and work in Collaboration. Can you please do that? |
#343 is an updated version of this @deepakbhansal, @rohanagarwal and @deepakbhansal can you to work forward on this in #343 please, it would be much better to do so. Shall I close this or as this is becoming old. |
@Abhi2424shek please close this. Unfortunately, this is not the correct way to solve this problem. I have updated my PR. Would love everyone to contribute to it. It may require time to understand my code since I took help from the official Wordpress android, but it is the correct way to go. |
Ok @deepakbhansal please follow up there, closing this one. |
Fixes issue #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshots for the change: