Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress Integration file with volley library #129

Closed

Conversation

deepakbansal168
Copy link

Fixes issue #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]

Changes: [Add here what changes were made in this issue and if possible provide links.]

Screenshots for the change:

@abishekvashok
Copy link
Member

Pls resolve the conflicts your fork seems to be behind.

@harsu-ag
Copy link

harsu-ag commented Mar 13, 2017

@deepakbansal168 @Abhi2424shek @pa1pal I am working on Authentication from - https://developer.wordpress.com/docs/oauth2/

Not saved to accounts database.
Added Todo's.
@harsu-ag
Copy link

harsu-ag commented Mar 14, 2017

I have done the OAuth part but needed some help regarding committing my changes to this PR.

I tried sending a PR to deepakbansal168:development fork, but I am unable to as I have forked the base branch. So, do I need a write access to the deepak's fork to directly commit my changes to this PR?

@abishekvashok
Copy link
Member

Yes, to directly commit you would need wrote access, however you could also sent a PR to his development branch which if he accepts and merge would become a merge commit and be shown here like a regular commit. @harsu-ag

@harsu-ag
Copy link

@Abhi2424shek I was not able to send a PR to his development branch. As I have already forked the fossasia project, I was not able to fork a deepak's fork.
So, I asked for a write access. 😄

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #129 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development    #129      +/-   ##
================================================
- Coverage           2.55%   2.54%   -0.01%     
  Complexity            90      90              
================================================
  Files                303     307       +4     
  Lines              39095   39245     +150     
  Branches            4881    4892      +11     
================================================
  Hits                 997     997              
- Misses             38007   38157     +150     
  Partials              91      91
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/vn/mbm/phimp/me/Blank.java 0% <ø> (ø) 0 <0> (ø) ⬇️
app/src/main/java/vn/mbm/phimp/me/newGallery.java 5.73% <ø> (ø) 11 <0> (ø) ⬇️
...java/vn/mbm/phimp/me/WordpressWebviewActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/vn/mbm/phimp/me/libraries/VolleyLibrary.java 0% <0%> (ø) 0 <0> (?)
...java/vn/mbm/phimp/me/AddAccountDialogFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...java/vn/mbm/phimp/me/libraries/LruBitmapCache.java 0% <0%> (ø) 0 <0> (?)
.../java/vn/mbm/phimp/me/libraries/CustomRequest.java 0% <0%> (ø) 0 <0> (?)
...a/vn/mbm/phimp/me/libraries/VolleyErrorHelper.java 0% <0%> (ø) 0 <0> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e15e0...6eed9a6. Read the comment docs.

@deepakbansal168
Copy link
Author

@harsu-ag i am still waiting for your update.

@abishekvashok
Copy link
Member

@deepakbhansal seems like @harsu-ag is not near, can you work on it on your own please. This is a critical part of the app, would you be needing any help?

@rohanagarwal94
Copy link
Contributor

@Abhi2424shek let me help out @deepakbansal168 with this.

@abishekvashok
Copy link
Member

Sure have a try.

@mariobehling
Copy link
Member

@deepakbansal168 Thanks for your contribution. Please help to resolve the conflicts.

@deepakbansal168
Copy link
Author

sure i will resolve the conflicts.

@abishekvashok
Copy link
Member

abishekvashok commented Apr 11, 2017

@rohanagarwal @deepakbansal168 is waiting for you, any inputs please, it would be awesome.

@rohanagarwal94
Copy link
Contributor

@Abhi2424shek it needs a lot of changes to bring this feature to execution. It requires me maximum a day more to figure everything out before I create a PR. I would request to close this PR since this is not a native solution and is using webview. In fact this code is not even fetching the media of a particular wordpress website. I will send the PR as soon as possible.

@abishekvashok
Copy link
Member

abishekvashok commented Apr 11, 2017

Please do work in collaboration with @deepakbansal168 @rohanagarwal :) It would be better if you two could communicate together and decide to who's fork the changes will be pushed and work in Collaboration. Can you please do that?

@abishekvashok
Copy link
Member

#343 is an updated version of this @deepakbhansal, @rohanagarwal and @deepakbhansal can you to work forward on this in #343 please, it would be much better to do so. Shall I close this or as this is becoming old.

@rohanagarwal94
Copy link
Contributor

@Abhi2424shek please close this. Unfortunately, this is not the correct way to solve this problem. I have updated my PR. Would love everyone to contribute to it. It may require time to understand my code since I took help from the official Wordpress android, but it is the correct way to go.

@abishekvashok
Copy link
Member

Ok @deepakbhansal please follow up there, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants