-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1440-Add a Square Fit editing option in the App #1817
Conversation
9c87d8c
to
c85e88c
Compare
c85e88c
to
8215329
Compare
8215329
to
db1d7e1
Compare
Please resolve codacy issues and the rest of the work here itself if possible. |
Ping @ashley8jain |
@abishekvashok it is one of challenge filter. I will do it as soon as possible. If anyone want to solve this filter, welcome. |
So what should I do, should I merge it? |
@abishekvashok ok I am rectifying now. |
SS - Screen Shot |
@yashLadha i just add three button on lower row and icon. as shown in screenshot in above description. Function of square Image is not implmented. |
@abishekvashok Done |
I will continue the work during GSOC '18 |
Yea I will merge this after the branch get's updated and the build finished. |
Can you change the title of the PR. It doesn't match the changes.
…On Wed 28 Mar, 2018, 4:29 PM Abishek V Ashok, ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1817 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARMqT4_Wt8ifGdhd1VV9s5-DE9lS0ZmGks5ti20mgaJpZM4R-zT5>
.
|
@ashley8jain Please update the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve conflicts
After feedback from devs on the channel, I am closing this. If this is still relevant and you want to commit it again, please reopen this PR or a new one. Thanks. |
First steps for issues #1140
Changes:
Screenshots for the change: