Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1440-Add a Square Fit editing option in the App #1817

Closed
wants to merge 16 commits into from

Conversation

ashley8jain
Copy link
Member

First steps for issues #1140

Changes:

  • ThreeItemFragment for three items in Transform UI
  • Square fit icon
  • Square fit Function

Screenshots for the change:
screenshot_20180208-234242

@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 8, 2018
@fossasia fossasia deleted a comment Feb 12, 2018
@fossasia fossasia deleted a comment Feb 21, 2018
@fossasia fossasia deleted a comment Feb 21, 2018
@abishekvashok
Copy link
Member

Please resolve codacy issues and the rest of the work here itself if possible.

@abishekvashok
Copy link
Member

Ping @ashley8jain

@ashley8jain
Copy link
Member Author

@abishekvashok it is one of challenge filter. I will do it as soon as possible. If anyone want to solve this filter, welcome.

@abishekvashok
Copy link
Member

So what should I do, should I merge it?

@ashley8jain
Copy link
Member Author

@abishekvashok ok I am rectifying now.
@yashLadha ss means?

@yashLadha
Copy link
Member

SS - Screen Shot

@ashley8jain
Copy link
Member Author

@yashLadha i just add three button on lower row and icon. as shown in screenshot in above description. Function of square Image is not implmented.

@ashley8jain
Copy link
Member Author

ashley8jain commented Mar 9, 2018

@abishekvashok Done

@fossasia fossasia deleted a comment Mar 11, 2018
@fossasia fossasia deleted a comment Mar 19, 2018
@ashley8jain
Copy link
Member Author

I will continue the work during GSOC '18

@abishekvashok
Copy link
Member

Yea I will merge this after the branch get's updated and the build finished.

@fossasia fossasia deleted a comment Mar 28, 2018
@yashLadha
Copy link
Member

yashLadha commented Mar 28, 2018 via email

@fossasia fossasia deleted a comment Mar 29, 2018
@sauravvishal8797
Copy link
Member

@ashley8jain Please update the branch.

@fossasia fossasia deleted a comment May 19, 2018
@fossasia fossasia deleted a comment May 26, 2018
@fossasia fossasia deleted a comment May 28, 2018
Copy link
Member

@batbrain7 batbrain7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts

@mariobehling
Copy link
Member

After feedback from devs on the channel, I am closing this. If this is still relevant and you want to commit it again, please reopen this PR or a new one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants