Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change play store icon #2815

Merged
merged 8 commits into from
Jul 10, 2019
Merged

Conversation

ranjsa
Copy link
Member

@ranjsa ranjsa commented Jul 8, 2019

Fixed #2731

Changes: Updated the icon in phimpme-android/app/src/main/ic_launcher-web.png

As first the icon was using the rounded mask but according to google guidelines shape of the icon should be full square and Google Play will dynamically handle masking .

Reference : https://developer.android.com/google-play/resources/icon-design-specifications

Screenshots of the change:

https://drive.google.com/file/d/1uvaEPvFM8BgarLJiCSBYk8JjK3ciCX6g/view?usp=sharing

@iamareebjamal
Copy link
Member

Too much padding

@yashk2000
Copy link
Member

Don't we have to replace the app icons currently in the 'mipmap` folders too?

@iamareebjamal
Copy link
Member

No

@yashk2000
Copy link
Member

But those aren't showing up in showing up in changed files right now.

@iamareebjamal
Copy link
Member

Don't we have to replace the app icons currently in the 'mipmap` folders too?

No

@yashk2000
Copy link
Member

Ohk.

abishekvashok
abishekvashok previously approved these changes Jul 9, 2019
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding is too much, and we want icon in fastlane metadats

@iamareebjamal
Copy link
Member

Now it's too less. Please use the gridline given by Google

@ranjsa
Copy link
Member Author

ranjsa commented Jul 9, 2019

ok .......

@ranjsa
Copy link
Member Author

ranjsa commented Jul 9, 2019

@iamareebjamal modified the icon according to google guidelines

@yashk2000
Copy link
Member

Looks better now. Can you please squash the commits?

@yashk2000 yashk2000 changed the title adding new icon chore: adding new icon Jul 9, 2019
@auto-label auto-label bot added the chore label Jul 9, 2019
abishekvashok
abishekvashok previously approved these changes Jul 9, 2019
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want icon in fastlane metadata

Please wait

@iamareebjamal
Copy link
Member

@ranjsa
Copy link
Member Author

ranjsa commented Jul 9, 2019

OK sure .....

@ranjsa
Copy link
Member Author

ranjsa commented Jul 9, 2019

@iamareebjamal files changed and commits squashed

@iamareebjamal
Copy link
Member

Resolve conflicts

@iamareebjamal
Copy link
Member

Irrelevant changes and 32 file changes

@ranjsa
Copy link
Member Author

ranjsa commented Jul 10, 2019

@iamareebjamal I don't know where i went wrong . I just squashed the commits and pushed my code . Can you please suggest me what should i do to resolve this conflicts .

@ranjsa
Copy link
Member Author

ranjsa commented Jul 10, 2019

I reverted back to previous commit .... Is it good now

@iamareebjamal iamareebjamal changed the title chore: adding new icon chore: change play store icon Jul 10, 2019
@iamareebjamal iamareebjamal merged commit 4fc9967 into fossasia:development Jul 10, 2019
iamareebjamal pushed a commit to iamareebjamal/phimpme-android that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt icon to new Google Playstore Requirements
4 participants