-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change play store icon #2815
Conversation
Too much padding |
Don't we have to replace the app icons currently in the 'mipmap` folders too? |
No |
But those aren't showing up in showing up in changed files right now. |
No |
Ohk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding is too much, and we want icon in fastlane metadats
Now it's too less. Please use the gridline given by Google |
ok ....... |
@iamareebjamal modified the icon according to google guidelines |
Looks better now. Can you please squash the commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want icon in fastlane metadata
Please wait
Please change this file and revert the ic_web.png |
OK sure ..... |
@iamareebjamal files changed and commits squashed |
Resolve conflicts |
Irrelevant changes and 32 file changes |
@iamareebjamal I don't know where i went wrong . I just squashed the commits and pushed my code . Can you please suggest me what should i do to resolve this conflicts . |
I reverted back to previous commit .... Is it good now |
Fixed #2731
Changes: Updated the icon in phimpme-android/app/src/main/ic_launcher-web.png
As first the icon was using the rounded mask but according to google guidelines shape of the icon should be full square and Google Play will dynamically handle masking .
Reference : https://developer.android.com/google-play/resources/icon-design-specifications
Screenshots of the change:
https://drive.google.com/file/d/1uvaEPvFM8BgarLJiCSBYk8JjK3ciCX6g/view?usp=sharing