Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Crash when recording at multimeter #1466

Closed
kksinghal opened this issue Dec 10, 2018 · 8 comments · Fixed by #1520
Closed

Unexpected Crash when recording at multimeter #1466

kksinghal opened this issue Dec 10, 2018 · 8 comments · Fixed by #1520
Assignees
Labels
Bug Unexpected problem or unintended behavior in app Help Wanted Maintainers need help on this Instrument: Multimeter

Comments

@kksinghal
Copy link

kksinghal commented Dec 10, 2018

Actual Behaviour
In multimeter , unexpected crash occurs on pressing delete after pausing the recording .
Please state here what is currently happening.

Expected Behaviour
The app should work smoothly.
State here what the feature should enable the user to do.

Steps to reproduce it
Go to multimeter , click on record , then pause and then on delete .
Add steps to reproduce bugs or add information on the place where the feature should be implemented. Add links to a sample deployment or code.

Screenshots of the issue
screenshot2

Where-ever possible add a screenshot of the issue.

Would you like to work on the issue?
No , just a review

@cweitat cweitat changed the title Unexpected Crash Unexpected Crash when recording at multimeter Dec 11, 2018
@CloudyPadmal CloudyPadmal added Bug Unexpected problem or unintended behavior in app Instrument: Multimeter labels Dec 13, 2018
@mariobehling mariobehling added the Help Wanted Maintainers need help on this label Dec 14, 2018
@ho-dor
Copy link
Contributor

ho-dor commented Dec 26, 2018

@CloudyPadmal @cweitat can I solve this in a similar way by using PSLabSensor abstract class ?

@CloudyPadmal
Copy link
Collaborator

CloudyPadmal commented Dec 26, 2018

PSLabSensor class is only for sensors. Other instruments need to be handled individually.

PS:

Sensors

  • Luxmeter
  • Barometer
  • Accelerometer
  • Compass
  • Temperature and Humidity etc

@ho-dor
Copy link
Contributor

ho-dor commented Dec 26, 2018

@CloudyPadmal So this will need the device to solve? Even if it does need the device , we should handle the crash with a toast for instance when device isn't connected.

@abhinavraj23
Copy link
Member

@CloudyPadmal @ho-dor I would like to take up the issue if it's okay

@abhinavraj23 abhinavraj23 self-assigned this Jan 4, 2019
@ho-dor
Copy link
Contributor

ho-dor commented Jan 4, 2019

@abhinavraj23 I want to learn the working of multimeter . I would like to help you in this if it's ok .

@abhinavraj23
Copy link
Member

abhinavraj23 commented Jan 5, 2019

@ho-dor It wasn't that big issue, it was actually a 2 min fix, and this issue was pending since many days so I thought of solving it. You may look at my PR for the fix.

@ho-dor
Copy link
Contributor

ho-dor commented Jan 5, 2019

Did this issue require the pslab device to solve ? @abhinavraj23

@abhinavraj23
Copy link
Member

No, I just added the condition that the recording will take place only when PSLab is connected which makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior in app Help Wanted Maintainers need help on this Instrument: Multimeter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants