Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play videos in the app #2109

Open
atm1504 opened this issue Mar 29, 2019 · 10 comments · May be fixed by #2488
Open

Play videos in the app #2109

atm1504 opened this issue Mar 29, 2019 · 10 comments · May be fixed by #2488
Labels
enhancement

Comments

@atm1504
Copy link
Member

atm1504 commented Mar 29, 2019 •
edited
Loading

Describe the feature you'd like
Currently, if we ask susi to play any video, it redirects to youtube. We can see in whatsapp that videos can be played inside the app. We should have a similar feature here. Its not always effective to move to youtube. If users want to ask to play another video, then he need to come back to the app. But if we have this feature, then user can easily use the app.

Additional context
User can easily cancel the video, and use the app.

Screenshots
WhatsApp Image 2019-03-30 at 1 24 56 AM

Would you like to work on the issue?
Yes
@atm1504
Copy link
Member Author

atm1504 commented Apr 5, 2019

@iamareebjamal can I use youtube api to make this add this feature?

@s-ayush2903
Copy link

@atm1504 Can i take this issue up to fix?

@atm1504
Copy link
Member Author

atm1504 commented Jan 10, 2020

Go ahead

@s-ayush2903 s-ayush2903 mentioned this issue Jan 12, 2020
Closed
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
adcbc8b 
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout

REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
9b195cd 
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout

REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
323055c 
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout

REQUIRED: Give YouTube API key for proper functioning
@shubhamkumar1739 shubhamkumar1739 linked a pull request Feb 9, 2020 that will close this issue
Open
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
1ebc893 
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout

REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
f791f8b 
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout

REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
79df4c8 
Add a fragment which plays YouTube videos in the app
YoutubeFragment.kt: A the fragment to play Youtube Videos
FullscreenListener.kt: Listens for full screen event
fragment_youtube.xml: Fragment layout

REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 9, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
d451427 
    Add a fragment which plays YouTube videos in the app
    YoutubeFragment.kt: A the fragment to play Youtube Videos
    FullscreenListener.kt: Listens for full screen event
    fragment_youtube.xml: Fragment layout

    REQUIRED: Give YouTube API key for proper functioning
shubhamkumar1739 added a commit to shubhamkumar1739/susi_android that referenced this issue Feb 13, 2020
@shubhamkumar1739
feat: Play videos in the app fossasia#2109
1e9fb07 
    Add a fragment which plays YouTube videos in the app
    YoutubeFragment.kt: A the fragment to play Youtube Videos
    FullscreenListener.kt: Listens for full screen event
    fragment_youtube.xml: Fragment layout

    Add a callback (ChatCallback) which plays youtube fragment from the ChatActivity

    REQUIRED: Give YouTube API key for proper functioning
@uonliaquat
Copy link

Is this issue still open?

@iamareebjamal
Copy link
Member

image

@uonliaquat
Copy link

This is my first time trying to contribute to an open source, so please let me know can I take this issue if its still open

@iamareebjamal
Copy link
Member

Open label in Green means open

@uonliaquat
Copy link

Thanks @iamareebjamal Then how would I be allowed to work on this issue like do I need to take someones permission or what? Who will assign me this?

@iamareebjamal
Copy link
Member

No need of assigning. Send a PR once you have fixed the issue

@uonliaquat
Copy link

Thanks @mariobehling for clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Play videos in the app #2109 shubhamkumar1739/susi_android
5 participants
@mariobehling @iamareebjamal @uonliaquat @atm1504 @s-ayush2903