Addresses #635 implemented statistic infobox similar to loklak #704

nikhilrayaprolu · 2017-08-02T20:16:52Z

Fixes issue #635

Implemented Statistic infobox that shows top providers, authors etc

Demo Link: http://susper-pr-704.herokuapp.com/

Screenshots for the change:

harshit98 · 2017-08-03T01:27:52Z

src/app/statsbox/statsbox.component.html

+
+      </ul>
+    </div>
+


Remove extra line.

harshit98 · 2017-08-03T01:27:58Z

src/app/statsbox/statsbox.component.html

+            {{element.name}} <span class="badge">{{element.count}}</span>
+          </a>
+        </li>
+


Remove extra line.

harshit98 · 2017-08-03T01:28:21Z

src/app/statsbox/statsbox.component.spec.ts

+        StatsboxComponent,
+      ],
+      providers: [
+


Since there are no providers, we can remove it.

harshit98 · 2017-08-03T01:28:56Z

src/app/statsbox/statsbox.component.ts

+  navigation$: Observable<any>;
+  selectedelements: Array<any> = [];
+  changeurl(modifier, element) {
+


Remove extra line.

harshit98 · 2017-08-03T01:30:20Z

@nikhilrayaprolu Please go through the suggested changes which need to be done. Since we're in the final phase of GSoC, it would be great if we maintain code quality too. :)

Fix Travis issue too. Good Work! 💯

Marauderer97

LGTM great work 💯

Marauderer97 · 2017-08-03T03:17:27Z

src/app/statsbox/statsbox.component.ts

+
+  }
+  ngOnInit() {
+


Please remove extra line

Marauderer97 · 2017-08-03T03:17:44Z

src/app/statsbox/statsbox.component.ts

+      this.querylook = Object.assign({}, query);
+      this.navigation$ = store.select(fromRoot.getNavigation);
+    });
+


Please remove extra line

nikhilrayaprolu · 2017-08-03T07:10:12Z

@harshit98 @Marauderer97 made the requested changes.

harshit98

Good work! 💯

mariobehling · 2017-08-03T07:52:08Z

Demo link not working on Chrome. Page is https.

I can see already the following:

Use same colors as exisintg
Use same box style and indents

Still need to test the links.

nikhilrayaprolu · 2017-08-03T09:51:19Z

@mariobehling please use this new deployment link at http://susper-pr-704.herokuapp.com/

Marauderer97

Please resolve travis

…com-1 into statsbox

nikhilrayaprolu · 2017-08-03T18:23:25Z

nikhilrayaprolu · 2017-08-03T18:25:00Z

@mariobehling done with the requested changes removed Protocol and collections since they don't make a meaning for user. I will make the distribution of Date and protocols in a new PR.

codecov · 2017-08-03T18:28:30Z

Codecov Report

Merging #704 into master will increase coverage by 0.35%.
The diff coverage is 65.57%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   58.94%   59.29%   +0.35%     
==========================================
  Files          46       47       +1     
  Lines         984     1049      +65     
  Branches      102      106       +4     
==========================================
+ Hits          580      622      +42     
- Misses        342      362      +20     
- Partials       62       65       +3

Impacted Files	Coverage Δ
src/app/services/speech-synthesis.service.ts	`26.31% <0%> (-1.47%)`	⬇️
src/app/statsbox/statsbox.component.ts	`66.66% <66.66%> (ø)`
src/app/auto-complete/auto-complete.component.ts	`41.17% <0%> (+1.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561e6ef...4e4bbaf. Read the comment docs.

mariobehling · 2017-08-04T07:04:28Z

@nikhilrayaprolu

What is the heading of the box? There is none currently?
Please position the sidebar boxes more smoothly in the design. The top box is not in the same line as the top text and the second box has a big space. Reduce the space.
Where did you get the idea for the gray boxes? They are very dominant. Please propose a less dominant design, that does not attract the attention of the user right away. The main focus of the page should always be the search results.
You show the top ten results. Please provide an option to view more results.
The first line below "top authors" does not show a name. What is this number related to? Undefined?

mariobehling · 2017-08-04T07:06:48Z

Adding this box now also adds another feature to the page that increases the issues with the design of the site in different resolutions. See the screenshot below with a number of display issues on large screens.

nikhilrayaprolu · 2017-08-04T20:48:32Z

@mariobehling updated the PR:

implemented more and less button that expands
less button

more button to get more options
left no margin b/w both infobox and statistic box, which is more better in user experience.
The statistic box is self explanatory with titles as Top Provider and Top Authors, so I think we don't need to have a heading to the box.
Grey color is changed to green
removed the undefined author.

Regarding the large screen the problem persists on susper.com and not generated in this PR we could solve that issue in #683

harshit98 · 2017-08-07T03:46:15Z

src/app/statsbox/statsbox.component.html

+            [labels]="lineChartLabels"
+            [options]="lineChartOptions"
+            [chartType]="lineChartType"
+            ></canvas>


Indent this line.

harshit98 · 2017-08-07T03:46:58Z

src/app/statsbox/statsbox.component.ts

+  }
+
+  public chartHovered(e: any): void {
+    console.log(e);


Remove console.log

harshit98 · 2017-08-07T03:47:09Z

src/app/statsbox/statsbox.component.ts

+  public lineChartLegend: boolean = true;
+  public lineChartType: string = 'line';
+  public chartClicked(e: any): void {
+    console.log(e);


Remove console.log

nikhilrayaprolu · 2017-08-07T19:53:54Z

@mariobehling made the requested changes

Regarding a monthly wise statistics, that could be implemented if we could so statistics of all results, but presently we are just showing the results of present page because to retrieving specific fields of a result could be done only when &wt=json but we can't do that when &wt=yjson but JSONP callback is supporting only yjson format. I think we can achieve that with a small change on the server side. @Orbiter
when wt=yjson

when wt=json

harshit98 · 2017-08-08T14:54:13Z

@nikhilrayaprolu Please follow up this commit: here and remove unnecessary import of modules from NotFoundComponent.

nikhilrayaprolu · 2017-08-08T16:44:28Z

@harshit98 sure, doing that now.

…com-1 into statsbox

nikhilrayaprolu · 2017-08-08T16:55:32Z

@harshit98 updated the pull removing all extra modules

harshit98 · 2017-08-08T16:56:43Z

Looks good to me now! We can merge this PR. Good work! 💯

mariobehling · 2017-08-08T18:55:21Z

Thank you! Please open an issue on the server regarding monthly and potentially weekly results. Cheers.

mariobehling · 2017-08-08T18:56:48Z

Please change "Protocol Frequency" to "Protocol Distribution" in a follow up PR as well.

nikhilrayaprolu · 2017-08-10T07:04:50Z

👍

Addresses fossasia#635 implemented statistic infobox similar to loklak

1fb2bd8

nikhilrayaprolu temporarily deployed to susper-pr-704 August 2, 2017 20:17 Inactive

Merge branch 'master' into statsbox

de4a65c

nikhilrayaprolu had a problem deploying to susper-pr-704 August 2, 2017 20:23 Failure

harshit98 reviewed Aug 3, 2017

View reviewed changes

src/app/statsbox/statsbox.component.html Outdated

</ul>

</div>

Copy link

Member

harshit98 Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line.

harshit98 reviewed Aug 3, 2017

View reviewed changes

Marauderer97 reviewed Aug 3, 2017

View reviewed changes

fixed lint errors

bcf9586

nikhilrayaprolu temporarily deployed to susper-pr-704 August 3, 2017 07:08 Inactive

harshit98 approved these changes Aug 3, 2017

View reviewed changes

Merge branch 'master' into statsbox

815d7fb

nikhilrayaprolu temporarily deployed to susper-pr-704 August 3, 2017 08:56 Inactive

Marauderer97 reviewed Aug 3, 2017

View reviewed changes

nikhilrayaprolu added 2 commits August 3, 2017 23:49

requested changes made

9876198

Merge branch 'statsbox' of https://github.com/nikhilrayaprolu/susper.…

c54f1b2

…com-1 into statsbox

nikhilrayaprolu temporarily deployed to susper-pr-704 August 3, 2017 18:22 Inactive

requested changes made

58b11a4

nikhilrayaprolu temporarily deployed to susper-pr-704 August 4, 2017 20:43 Inactive

harshit98 reviewed Aug 7, 2017

View reviewed changes

src/app/statsbox/statsbox.component.ts Outdated

}

public chartHovered(e: any): void {

console.log(e);

Copy link

Member

harshit98 Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log

harshit98 reviewed Aug 7, 2017

View reviewed changes

made requested changes

2b5ebc7

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 19:31 Inactive

nikhilrayaprolu added 2 commits August 8, 2017 01:12

requested changes made

6c1a34e

statistics is changed to analytics

144e9b8

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 19:43 Inactive

changed the font size of analytics

7423b94

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 19:45 Inactive

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 19:47 Inactive

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 19:56 Inactive

nikhilrayaprolu force-pushed the statsbox branch from a0b041a to 7423b94 Compare August 7, 2017 20:00

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 20:00 Inactive

Merge branch 'master' into statsbox

85f483e

nikhilrayaprolu temporarily deployed to susper-pr-704 August 7, 2017 20:01 Inactive

nikhilrayaprolu added 2 commits August 8, 2017 22:23

removed all extra modules in tests

47d0b4a

Merge branch 'statsbox' of https://github.com/nikhilrayaprolu/susper.…

854e0a9

…com-1 into statsbox

nikhilrayaprolu temporarily deployed to susper-pr-704 August 8, 2017 16:54 Inactive

rearranged positions

4e4bbaf

nikhilrayaprolu deployed to susper-pr-704 August 8, 2017 17:42 View deployment

mariobehling merged commit c66ff98 into fossasia:master Aug 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addresses #635 implemented statistic infobox similar to loklak #704

Addresses #635 implemented statistic infobox similar to loklak #704

nikhilrayaprolu commented Aug 2, 2017 •

edited

harshit98 Aug 3, 2017

harshit98 Aug 3, 2017

harshit98 Aug 3, 2017

harshit98 Aug 3, 2017

harshit98 commented Aug 3, 2017 •

edited

Marauderer97 left a comment

Marauderer97 Aug 3, 2017

Marauderer97 Aug 3, 2017

nikhilrayaprolu commented Aug 3, 2017

harshit98 left a comment

mariobehling commented Aug 3, 2017

nikhilrayaprolu commented Aug 3, 2017

Marauderer97 left a comment

nikhilrayaprolu commented Aug 3, 2017

nikhilrayaprolu commented Aug 3, 2017 •

edited

codecov bot commented Aug 3, 2017 •

edited

mariobehling commented Aug 4, 2017

mariobehling commented Aug 4, 2017

nikhilrayaprolu commented Aug 4, 2017 •

edited

harshit98 Aug 7, 2017

harshit98 Aug 7, 2017

harshit98 Aug 7, 2017

nikhilrayaprolu commented Aug 7, 2017

harshit98 commented Aug 8, 2017

nikhilrayaprolu commented Aug 8, 2017

nikhilrayaprolu commented Aug 8, 2017

harshit98 commented Aug 8, 2017

mariobehling commented Aug 8, 2017

mariobehling commented Aug 8, 2017

nikhilrayaprolu commented Aug 10, 2017

Addresses #635 implemented statistic infobox similar to loklak #704

Addresses #635 implemented statistic infobox similar to loklak #704

Conversation

nikhilrayaprolu commented Aug 2, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshit98 commented Aug 3, 2017 • edited

Marauderer97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhilrayaprolu commented Aug 3, 2017

harshit98 left a comment

Choose a reason for hiding this comment

mariobehling commented Aug 3, 2017

nikhilrayaprolu commented Aug 3, 2017

Marauderer97 left a comment

Choose a reason for hiding this comment

nikhilrayaprolu commented Aug 3, 2017

nikhilrayaprolu commented Aug 3, 2017 • edited

codecov bot commented Aug 3, 2017 • edited

Codecov Report

mariobehling commented Aug 4, 2017

mariobehling commented Aug 4, 2017

nikhilrayaprolu commented Aug 4, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhilrayaprolu commented Aug 7, 2017

harshit98 commented Aug 8, 2017

nikhilrayaprolu commented Aug 8, 2017

nikhilrayaprolu commented Aug 8, 2017

harshit98 commented Aug 8, 2017

mariobehling commented Aug 8, 2017

mariobehling commented Aug 8, 2017

nikhilrayaprolu commented Aug 10, 2017

nikhilrayaprolu commented Aug 2, 2017 •

edited

harshit98 commented Aug 3, 2017 •

edited

nikhilrayaprolu commented Aug 3, 2017 •

edited

codecov bot commented Aug 3, 2017 •

edited

nikhilrayaprolu commented Aug 4, 2017 •

edited