Cypress Tests for -use_frontend_client_polling variant of visdom #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensuring functionality also using the
-use_frontend_client_polling
flag.Motivation and Context
Regarding the recent proxy-users and an upcoming code simplification of the server socket handlers, I suggest to add some testing of the polling-feature.
I have explicitly only added the "functional tests" to be tested against the
-use_frontend_client_polling
flag, which I though should be sufficient.In addition, a few minor changes were necessary in the following test cases:
image_callback
andimage_callback2
failed now and then for the poller-implementation, but not for the websocket implementation. This was due to two windows being loaded in different orders in both implementation. (The image-panes load slower when using long polling). This PR solves this by adapting all cypress selectors for image panes to use a "pane with an Image" instead of the "first" pane in the list of panes.wait(500)
commands in between the respective pane-creation commands.text_callback
test failed randomly as well. This is probably due to too a missing order-enforcement of the events when passing incoming events to the callback. (Not sure here. Is this correct?). This PR increases the delay in-between callback keystrokes to200ms
(from previously50ms
) to solve the issue of inconsistent tests.How Has This Been Tested?
Testing using this very PR-action, which should already include the test.
Also, to test for consistency, I've triggered the exact same action onto 10 branches, see for instance here
Types of changes
Checklist:
py/visdom/VERSION
according to Semantic Versioning