Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event list widget defaults to yesterday rather than today #60

Open
6 tasks done
nehemiagurl opened this issue Jan 11, 2024 · 6 comments · May be fixed by #186
Open
6 tasks done

Event list widget defaults to yesterday rather than today #60

nehemiagurl opened this issue Jan 11, 2024 · 6 comments · May be fixed by #186
Labels
bug Something is not working

Comments

@nehemiagurl
Copy link

Checklist

  • I can reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Describe the bug
When using the event list widget, the default/"baseline" date appears to be yesterday rather than today. This happens both when adding the widget and when clicking on the "today" button (the skeuomorph of a calendar with a small square in it at the top right corner).

To Reproduce
When adding the widget

  1. Go to widgets>Fossify Calendar and add the event list widget.
  2. Click "OK" on the config screen.
  3. The widget loads events, with the start of yesterday being focused on by default.
    When clicking on the "today" button
  4. Scroll down to a random point in time.
  5. Click on the "today" button at the top right corner.
  6. The widget scrolls all the way back to the start of yesterday.

Expected behavior
For both cases, the widget should default to today, with yesterday's event visible by scrolling up but out of view at the beginning.
Even preferably in my opinion, in both cases the widget should default to right now, i.e. with events that already happened today out of view. But that is a matter of opinion, and the start of today (with events today that already happened in view) is also acceptable.

Screenshots
This video demonstrates clicking the "today" button multiple times (each time the widget reloads happens after a click). When adding the widget you get to the same point as if you just clicked the "today" button.
https://github.com/FossifyOrg/Calendar/assets/109424320/583efbb2-ab42-4638-bb35-e6d6f843755f

Device info (please complete the following information):

  • Model: Galaxy A12
  • OS: Android 12
  • App version 1.0.2 (early access)

Additional context
The main issue with this behaviour is you always have to scroll to see the closest upcoming events.

@nehemiagurl nehemiagurl added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 11, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 11, 2024
@SunFlowerTos
Copy link

Hello @Aga-C, @apoumier and I are students at Paris 8 University and we have to chose a free software project to contribute to. We managed to reproduce this bug and we would like to resolve this issue. We will start working on it soon.

@apoumier
Copy link

apoumier commented Feb 4, 2024

Hello, is it still possible to resolve this issue with @SunFlowerTos ? We would like to start working on it as part of our free software development course.

@Aga-C
Copy link
Member

Aga-C commented Feb 4, 2024

If there's no needs triage label, you can just work on an issue. You don't need to be assigned to it or have any permission to do it.

@Gymcap
Copy link

Gymcap commented May 21, 2024

This could be optional. The default to be to suppress 'yesterday' from entering the list, with a toggle option to show yesterday when creating the widget. In this suggestion the toggle would be on the same screen as the "Show events happening within..." option, after initially placing the widget on your home screen.

@Gymcap
Copy link

Gymcap commented May 21, 2024

Here is an example mockup I made in gimp.
🗿

@Aga-C
Copy link
Member

Aga-C commented May 21, 2024

@Gymcap There's already Display events from the past in settings where users can configure this for all event list widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
5 participants