Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation constructor start_datetime default argument potentially causes bugs #156

Open
jfeodor opened this issue Jun 2, 2022 · 0 comments

Comments

@jfeodor
Copy link
Contributor

jfeodor commented Jun 2, 2022

start_datetime=datetime.now(), **kwargs):

I randomly stumbled upon this line in the the Simulation class constructor. The start_datetime argument has the default argument datetime.now(), which is evaluated when the class is defined, and not when it is instantiated. Alternatively the default argument could be None, and then redefined to datetime.now() inside the function body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant