Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacechem fails + ^C not done right #27

Closed
Kwpolska opened this issue Sep 20, 2012 · 12 comments
Closed

spacechem fails + ^C not done right #27

Kwpolska opened this issue Sep 20, 2012 · 12 comments

Comments

@Kwpolska
Copy link
Contributor

[kwpolska@kwpolska-lin ~]% pkgbuilder -S spacechem 
==> Building spacechem...
  -> games/spacechem 1012-2 (24 votes)
  ->     an obscenely addictive, design-based puzzle game about building machines and fighting monsters in the name of science!
==> Downloading the tarball...
  -> 1.695 kB downloaded
==> Extracting...
  -> 4 files extracted
==> Checking dependencies...
  -> sdl: found in system
  -> mono: found in system
  -> sdl_image: found in system
  -> sdl_mixer: found in system
  -> xclip: found in system
==> Making package: spacechem 1012-2 (Thu Sep 20 18:00:22 CEST 2012)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving Sources...
  -> Found spacechem.sh
  -> Found spacechem.desktop
==> Validating source files with md5sums...
    spacechem.sh ... Passed
    spacechem.desktop ... Passed
==> Extracting Sources...
==> Starting build()...
==> You need a full copy of this game in order to install it
==> Searching for spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb in dir: "/tmp/pkgbuilder-1000/spacechem/src"
==> ERROR: Game package not found, please type absolute path to spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb (/home/joe):

Now, let’s try the same with aura.

[kwpolska@kwpolska-lin ~]% sudo aura -A spacechem
aura >>= Determining dependencies...
aura >>= Main AUR packages:
spacechem

aura >>= Continue? [y/n] y
aura >>= Building `spacechem`...
aura >>= Well, building `spacechem` failed.
aura >>= Dumping makepkg output in 3.. 2.. 1..
==> You need a full copy of this game in order to install it
==> Searching for spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb in dir: "/var/cache/pacman/pkg/spacechem-6499/spacechem/src"
==> ERROR: Game package not found, please type absolute path to spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb (/home/joe):
==> ERROR: A failure occurred in build().
    Aborting...

==> Making package: spacechem 1012-2 (Thu Sep 20 18:02:57 CEST 2012)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving Sources...
  -> Found spacechem.sh
  -> Found spacechem.desktop
==> Validating source files with md5sums...
    spacechem.sh ... Passed
    spacechem.desktop ... Passed
==> Extracting Sources...
==> Starting build()...

aura >>= Some packages may have built properly.
aura >>= Would you like to install them? [y/n] 

Now, that is not right. And this is not easily discoverable. (it failed immediately when the read was done)

Now, I am aware of -Ax. It works. But then I tried to quit. I had to hit ^C three times. THREE. This is too much.

[kwpolska@kwpolska-lin ~]% sudo aura -Ax spacechem
aura >>= Determining dependencies...
aura >>= Main AUR packages:
spacechem

aura >>= Continue? [y/n] y
aura >>= Building `spacechem`...
==> Making package: spacechem 1012-2 (Thu Sep 20 18:11:28 CEST 2012)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving Sources...
  -> Found spacechem.sh
  -> Found spacechem.desktop
==> Validating source files with md5sums...
    spacechem.sh ... Passed
    spacechem.desktop ... Passed
==> Extracting Sources...
==> Starting build()...
==> You need a full copy of this game in order to install it
==> Searching for spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb in dir: "/var/cache/pacman/pkg/spacechem-12460/spacechem/src"
==> ERROR: Game package not found, please type absolute path to spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb (/home/joe):
^C
Session terminated, killing shell...
==> ERROR: TERM signal caught. Exiting...
^C ...killed.
aura >>= Well, building `spacechem` failed.
aura >>= Some packages may have built properly.
aura >>= Would you like to install them? [y/n] ^C%                                                                                                                                                                                           

(% is printed, with reversed colors, when a command ended execution without a \n. This becomes a # as root, and it represents the prompt that would normally get printed there if you used a dumber shell (bash/sh).

Also, about that “built properly” thing, it would be a good idea to show a list of those packages and ignore it altogether if empty.

@fosskers
Copy link
Owner

  1. Thank you for this. I knew somewhere at the back of my mind that this would probably happen, but hoped it would never come up, lol. I also figured that -Ax would fix it.
  2. I didn't have the same problem with ^C.
  3. You're absolutely right about the built properly thing. It actually annoys me sometimes. It coming up and not producing a list of what has been built (most of the time there wasn't actually anything) is due to the process being recursive. I suppose I could attempt to make it tail-call, passing forward all the completed packages so they could be listed.
  4. Spacechem is an awesome game. You should try FTL.

@fosskers
Copy link
Owner

In fact, I'm going to open a separate issue concerning the "built properly" thing. Note that I've had that ^C thing happen with other programs (not aura) before. Sometimes the shell just doesn't respond as quickly as it should. Can you test this again? I'm tempted to just close this issue.

@Kwpolska
Copy link
Contributor Author

I do own it (<3 HIB, although the current one sucks), but I usually play games on Windows.


Tried that four times, and all four times had to hit ^C a bazillion times. So there might be something broken.

@fosskers
Copy link
Owner

I tried it again and nothing was wrong. Maybe your shell is to blame?

(aaaaand I just played FTL for like... 4 hours. So tired.)

@Kwpolska
Copy link
Contributor Author

fish (your shell) also fails over here. Also, it is annoying because it asks for the sudo password EVERY. GODDAMN. TIME.

@fosskers
Copy link
Owner

Of course it does. Unless you're in the 5 minute window that sudo allows before prompting you again. Running with sudo is very necessary for quite a few internal things to work.

@Kwpolska
Copy link
Contributor Author

It doesn’t at this end. Love when stuff breaks up only for one person and works just fine for everyone else.

Out of curiosity, I will test it on a different setup. Will post results soon.

@fosskers
Copy link
Owner

Please and thank you. I'm going to bed now... been up way too long. Talk to you tomorrow, probably.

@dkasak
Copy link
Contributor

dkasak commented Sep 22, 2012

I just tried this and a single ^C exits immediately for me also. It also looks a bit different than Kwpolska's:

==> Searching for spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb in dir: "/var/cache/pacman/pkg/spacechem-26515/spacechem/src"
==> ERROR: Game package not found, please type absolute path to spacechem_1012_amd64.tar.gz or SpaceChem-1012.tar.gz or spacechem-linux-1345144627-amd64.deb (/home/joe):
^C
==> ERROR: Aborted by user! Exiting...
aura >>= Well, building spacechem failed.

I'm using bash FWIW.

@Kwpolska
Copy link
Contributor Author

Tested that on my “different setup” (which is an Arch VM, purpose of which is to have a sane working environment in Windows) and it is the exact same.

@dkasak: Do you get to the prompt after that? No some packages may have been built but I have been programmed in a very dumb manner and I have absolutely no idea if there are any so I will go for a random call to pacman -U and will try to install them if you will let me message?

@dkasak
Copy link
Contributor

dkasak commented Sep 23, 2012

@Kwpolska: Ah, no, sorry, I do get that message; I just dumbly pasted a snippet instead of the whole thing. :-) The output is exactly the same as your -Ax output, except for the part that I pasted. I have no "Session terminated, ..." and "TERM signal caught..." stuff. I'd paste it again, but it seems that AUR is currently down.

@fosskers
Copy link
Owner

@Kwpolska Recursion is not dumb. I just happened to not make the process tail-call because it was more elegant that way. Please don't insult my source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants