File rename fails with --allsource

[pvsr]

Any package I try to install with --allsource errors out with something like this:

==> Making package: aura-git 2.0.0.r1465.4c6c481-2 (Sat 22 Jun 2019 08:40:12 PM EDT)
==> Retrieving sources...
  -> Cloning aura-git git repo...
Cloning into bare repository '/tmp/aura-git-3765352355900081325/aura-git/aura-git'...
remote: Enumerating objects: 565, done.
remote: Counting objects: 100% (565/565), done.
remote: Compressing objects: 100% (215/215), done.
remote: Total 11068 (delta 344), reused 478 (delta 297), pack-reused 10503
Receiving objects: 100% (11068/11068), 5.09 MiB | 5.28 MiB/s, done.
Resolving deltas: 100% (7115/7115), done.
==> Validating source files with md5sums...
    aura-git ... Skipped
==> Entering fakeroot environment...
==> Creating source package...
  -> Adding PKGBUILD...
  -> Generating .SRCINFO file...
  -> Adding aura-git...
  -> Compressing source package...
==> Leaving fakeroot environment.
==> Source package created: aura-git (Sat 22 Jun 2019 08:40:14 PM EDT)
==> Making package: aura-git 2.0.0.r1465.4c6c481-2 (Sat 22 Jun 2019 08:40:15 PM EDT)
==> ERROR: A source package has already been built. (use -f to overwrite)
aura: /tmp/aura-git-3765352355900081325/aura-git/aura-git-2.0.0.r1465.4c6c481-2.src.tar.gz: renameFile:renamePath:rename: unsupported operation (Invalid cross-device link)

I have / and /boot on two partitions of the same device and another drive mounted under /media, so I don't know where the cross-device thing is coming from. This is with the current git master.

[fosskers]

This was a problem quite a long time ago, when packages were built in /tmp. Let me check this again.

[fosskers]

Ah my mistake - it seems that the --allsource functionality we had given Aura is just completely broken. Fixing it now.

[fosskers]

git clone https://aur.archlinux.org/aura-bin.git
cd aura-bin
makepkg --allsource
# ... Work ...
ls

and we see:

aura-2.3.0-x86_64.tar.gz  aura-bin-2.3.0-1.src.tar.gz  PKGBUILD  src/

Where aura-bin-2.3.0-1.src.tar.gz is the tarball produced by --allsource.
It seems that Aura's --allsource is able to get this far too, but then gets confused about what to do with the file afterwards. I think we expected behaviour would be to just leave it, and not try and copy it to the package cache with the intent of installing it, since there's nothing to install.

[fosskers]

colin@yumi ~/beef> sudo aura -Ax aura-bin --allsource
[sudo] password for colin: 
aura >>= Determining dependencies...
aura >>= AUR Packages:
aura-bin
aura >>= Continue? [Y/n] 
aura >>= Building aura-bin...
# ... Work ...
==> Leaving fakeroot environment.
==> Source package created: aura-bin (Wed 13 May 2020 10:45:26 AM PDT)
==> Making package: aura-bin 2.3.0-1 (Wed 13 May 2020 10:45:27 AM PDT)
==> ERROR: A source package has already been built. (use -f to overwrite)
aura: /home/colin/beef/aura-bin-1553585085333874906/aura-bin/aura-bin-2.3.0-1.src.tar.gz: renameFile:renamePath:rename: does not exist (No such file or directory)

Notice Source package created. We don't see that message when building normally, so we know --allsource is at least being passed down to makepkg properly.

[fosskers]

Nevermind, we do copy it to a deterministic location:

srcPkgStore :: FilePath
srcPkgStore = "/var/cache/aura/src"

The problem here is that when --allsource is called by Aura, it is running makepkg twice. I think use of --allsource should prevent the build, and just produce the .src.tar.gz.

[fosskers]

Fixed. The change will be included in Aura's upcoming release. Thanks for your patience, and sorry about the wait.