Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aura can't find libc++ even though it's an AUR package #630

Closed
feroldi opened this issue Sep 9, 2020 · 5 comments · Fixed by #631
Closed

Aura can't find libc++ even though it's an AUR package #630

feroldi opened this issue Sep 9, 2020 · 5 comments · Fixed by #631
Labels

Comments

@feroldi
Copy link

feroldi commented Sep 9, 2020

Running the following gives an error:

$ sudo aura -A libc++ libc++abi
aura >>= The following are not AUR packages:
libc++
libc++abi
aura >>= No valid packages specified.

Aura says libc++ and libc++abi aren't AUR packages. They actually are:

However, when I use the %2B encoded character instead of +, aura then is able to find those packages.

@fosskers fosskers added the bug label Sep 11, 2020
@fosskers
Copy link
Owner

fosskers commented Sep 11, 2020

I had thought this bug already fixed, but sure enough it looks like the fix only applied to official packages and not for AUR lookups:

-- | If given a virtual package, try to find a real package to install.
resolveName :: MVar () -> Settings -> PkgName -> IO (Either PkgName (PkgName, Provides))
resolveName mv ss pn = do
  provs <- map PkgName <$> pacmanLines (envOf ss) ["-Ssq", "^" <> escape (pnName pn) <> "$"]
  case provs of
    [] -> pure $ Left pn
    _  -> Right . (, Provides pn) <$> chooseProvider mv ss pn provs
  where
    escape :: Text -> Text
    escape = T.foldl' f ""

    f :: Text -> Char -> Text
    f acc '+' = acc <> "\\+"
    f acc c   = T.snoc acc c

@fosskers
Copy link
Owner

fosskers commented Sep 11, 2020

I'm going to call this a bug in the underlying aur lib and fix it there.

One should be able to just call info "libc++" naively and have it "just work".

@fosskers fosskers linked a pull request Sep 11, 2020 that will close this issue
@fosskers
Copy link
Owner

Progress!

> aura -Ai libc++
Repository  : aur
Name        : libc++
Version     : 10.0.0-1
AUR Status  : Up to Date
Maintainer  : WoefulDerelict
Project URL : https://libcxx.llvm.org/
AUR URL     : https://aur.archlinux.org/packages/libc++
License     : custom:Apache 2.0 with LLVM Exception
Depends On  : libc++abi=10.0.0-1
Build Deps  : clang cmake llvm libunwind ninja python
Votes       : 248
Popularity  : 0.80
Description : LLVM C++ standard library.

@fosskers
Copy link
Owner

I'm able to build libc++ now.

@fosskers
Copy link
Owner

This fix for this will be included in the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants