Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add short form for --hotedit option #643

Closed
ratijas opened this issue Oct 4, 2020 · 8 comments · Fixed by #648
Closed

[Enhancement] Add short form for --hotedit option #643

ratijas opened this issue Oct 4, 2020 · 8 comments · Fixed by #648

Comments

@ratijas
Copy link
Contributor

ratijas commented Oct 4, 2020

Summary

Add shorthand (single-letter) form for aura's --hotedit option of -A operation. I suggest -e because E stands for Edit.

Description

Editing abandoned, broken or otherwise not out-of-the-box-AUR suitable packages is quite common task in my daily interaction with AUR helpers. Thus, I used to use -e as a short form of option to edit package's PKGBUILD. I would love to see this shortcut available in aura.

Alternatives

Pacaur supports -Se options combo.

Trizen has an opposite flag: --noedit.

Yay has many unconventional options related to editing PKGBUILD, e.g. --[no]answeredit, --[no]editmenu, --editor and --editorflags.

Version

$ aura -Qi aura
Name            : aura-bin
Version         : 3.1.9-1
Build Date      : Tue Sep 29 16:46:45 2020
@fosskers
Copy link
Owner

fosskers commented Oct 5, 2020

I had always been adverse to giving --hotedit and shorthand because I felt that people should be very careful when choosing to overwrite a PKGBUILD, but I suppose even with a short -e there are many opportunities after that to "turn back" and not edit, or not go through with building with the altered PKGBUILD. I can add this for you.

@ratijas
Copy link
Contributor Author

ratijas commented Oct 6, 2020

Btw, today I tried out --hotedit on already built & installed package, and to my surprise aura never prompted me to edit PKGBUILD — it just reinstalled existing bundle.

@fosskers
Copy link
Owner

fosskers commented Oct 6, 2020

If Aura sees you already have the exact version in your cache, it just grabs that and installs it. --force will rebuild it anyway, at which point --hotedit should activate.

@ratijas
Copy link
Contributor Author

ratijas commented Oct 6, 2020

Oh, it slipped my mind. Would it make sense to warn the user about ignored --hotedit then? 'cause I was lazy to read man-pages, and resorted to using a different AUR helper.

@fosskers
Copy link
Owner

fosskers commented Oct 6, 2020

Good idea, I'll add that.

@fosskers fosskers linked a pull request Oct 7, 2020 that will close this issue
@fosskers
Copy link
Owner

fosskers commented Oct 7, 2020

> sudo aura -Ae alsi
aura >>= Determining dependencies...
aura >>= AUR Packages:
alsi
aura >>= Continue? [Y/n] 
aura >>= --hotedit detected, but the following have entries in the cache and will be skipped:
  - alsi-0.4.8-1-any.pkg.tar.xz
aura >>= You can use --force to override this behaviour.
loading packages...
warning: alsi-0.4.8-1 is up to date -- reinstalling
resolving dependencies...
looking for conflicting packages...
...

@fosskers
Copy link
Owner

fosskers commented Oct 7, 2020

Slightly clearer message:

aura >>= --hotedit detected, but the following have cache entries and will be skipped for editing:

@ratijas
Copy link
Contributor Author

ratijas commented Oct 7, 2020

Top of the top. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants