Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print message when comparison rows are over 100. #39

Merged
merged 7 commits into from Jul 15, 2022
Merged

Print message when comparison rows are over 100. #39

merged 7 commits into from Jul 15, 2022

Conversation

dd-jy
Copy link
Contributor

@dd-jy dd-jy commented Jul 13, 2022 •
edited by bjk7119

Signed-off-by: Jiyeong Seok jiyeong.seok@lge.com

Description

  • Print message when comparison rows are over 100.
  • Add progress bar

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@dd-jy
Print message when comparison rows are over 100.
cec85e8 
Signed-off-by: Jiyeong Seok <jiyeong.seok@lge.com>
@dd-jy dd-jy added the chore [PR/Issue] Refactoring, maintenance the code label Jul 13, 2022
@dd-jy dd-jy requested a review from soimkim July 13, 2022 09:46
@dd-jy dd-jy self-assigned this Jul 13, 2022
@soimkim
Copy link
Contributor

soimkim commented Jul 15, 2022

@dd-jy , Plz update min version of fl_util in requiremets.txt.
error : No module named 'fosslight_util.compare_yaml'

@dd-jy
Fix the magic num
f18cc23 
Signed-off-by: Jiyeong Seok <jiyeong.seok@lge.com>
@dd-jy
Merge branch 'develop'
fd0a44a
@dd-jy
Fix not to print version N/A for comparison result
0d00cf6 
Signed-off-by: Jiyeong Seok <jiyeong.seok@lge.com>
@dd-jy
Fix not to print version N/A for comparison result
6ed9bda 
Signed-off-by: Jiyeong Seok <jiyeong.seok@lge.com>
@dd-jy
Add the info message
5ea3872 
- generate xlsx by default in html format

Signed-off-by: Jiyeong Seok <jiyeong.seok@lge.com>
soimkim
soimkim approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@soimkim soimkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interesting thing is that the same commit is stacked twice.

@dd-jy dd-jy merged commit 78f0799 into main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soimkim soimkim soimkim approved these changes

Assignees

@dd-jy dd-jy

Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dd-jy @soimkim @bjk7119