Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nltk dependency from project #24

Closed
mcjaeger opened this issue Jul 14, 2018 · 3 comments
Closed

Remove nltk dependency from project #24

mcjaeger opened this issue Jul 14, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@mcjaeger
Copy link
Member

nltk is used:

https://github.com/siemens/atarashi/blob/master/requirements.txt

but unfortunately not compatible with a GPL-2.0-only project:

https://www.apache.org/licenses/GPL-compatibility.html
https://www.gnu.org/licenses/license-list.html
@mcjaeger mcjaeger added the enhancement New feature or request label Jul 14, 2018
@GMishx
Copy link
Member

GMishx commented Jul 16, 2018

NLTK is used only for split as of now. And since data is already cleared in pre-processing by removing all the punctuations. So normal Python split can work in this case.

@amanjain97
Copy link
Collaborator

Please check with the PR #23

@amanjain97
Copy link
Collaborator

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcjaeger @amanjain97 @GMishx