Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ProblemChecker output #49

Closed
fosspill opened this issue Jun 4, 2019 · 1 comment
Closed

Better ProblemChecker output #49

fosspill opened this issue Jun 4, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fosspill
Copy link
Owner

fosspill commented Jun 4, 2019

The problemchecker output today is an overwhelming stream of useless information. It's like going to the doctor and receiving a 500 page report on every single bone in your body where the one broken one is mentioned on page 324 section 3 paragraph 5.

This really needs to be made cleaner. I'd gladly work on this, but I'd need some pointers about where to start (do I create a global array or a function in the problemchecker class that stores the issues and resolutions?)

Feature branch for better problem checker output is made.

I suggest something akin to this:


Checking for XXX problems..
44%...
Checkin for YYY problems ...
69%...
Checking for mod problems...
10%

The following problems were found and resolved:
oaisfoiahf oiahfioahfioh
GsdgS
DgSDGsdgsdg

ERROR: The following problems could not be resolved:
Broken toe. Please visit doctor.
@fosspill fosspill added the enhancement New feature or request label Jun 4, 2019
@fosspill fosspill self-assigned this Jun 4, 2019
@shinnova
Copy link
Collaborator

shinnova commented Jun 4, 2019

Creating an array in the problemchecker function sounds like the way to go, as you can make the individual checks return any issues found and add them to the array. If the array doesn't contain anything after the last check this means everything is okay, otherwise show what issues were found.

@shinnova shinnova self-assigned this Jun 7, 2019
@fosspill fosspill added this to the v0.4 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants