Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use wizard selection logic for normal modpack imports #68

Closed
shinnova opened this issue Jul 2, 2019 · 2 comments · Fixed by #86
Closed

[FEATURE] Use wizard selection logic for normal modpack imports #68

shinnova opened this issue Jul 2, 2019 · 2 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@shinnova
Copy link
Collaborator

shinnova commented Jul 2, 2019

We should consider using the current wizard import logic for regular modpack imports when using the --custom flag instead of/as alternative to the config files that are in use currently.

Describe the solution you'd like
Allow picking what modifications to import when importing a modpack through the same selection method as the wizard import.

@shinnova shinnova added the enhancement New feature or request label Jul 2, 2019
@fosspill fosspill added this to the Version 1 milestone Jul 2, 2019
@fosspill
Copy link
Owner

fosspill commented Jul 2, 2019

The bad:
Scrollback lines.

The good:
Easier to maintain. Easier to use.

My suggestion would be to "fake" pages. Maybe with up to 50 on each:

> ffmt -t HUGE.ttmp --custom
Starting import...
Extracting data from testwizard.ttmp2...
Starting wizard...

Name: testwizard
Version: 1.0.0
Author: nova
This is to test multi options in a modpack wizard

The test group
Page: 1 out of 10
Choices:
    0 - Nr 1
        this is nr 1
    1 - Nr 2
        and number two
    2 - Nr 3
        dis be 3
Choose one or multiple (eg: 1 2 3, 0-3, *): 2

Page: 2 out of 10
Choices:
    0 - Nr 1
        this is nr 1
    1 - Nr 2
        and number two
    2 - Nr 3
        dis be 3
Choose one or multiple (eg: 1 2 3, 0-3, *): 2

@fosspill
Copy link
Owner

fosspill commented Jul 2, 2019

We should get rid of --custom all together and give a proper option when importing a simple modpack.

> ffmt -t HUGE.ttmp
Starting import...
Extracting data from testwizard.ttmp2...

Simple Modpack detected

Use Wizard?
(Y)es, let me select the mods.
(N)o, import everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants