Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packer.CombineDuplicate incorrectly combines images when trimming #51

Closed
NoelFB opened this issue Jan 2, 2024 · 1 comment
Closed

Packer.CombineDuplicate incorrectly combines images when trimming #51

NoelFB opened this issue Jan 2, 2024 · 1 comment

Comments

@NoelFB
Copy link
Collaborator

NoelFB commented Jan 2, 2024

If Packer has both CombineDuplicates and Trim enabled, it will combine images that share the same data but have different trim values, which is incorrect. Each entry must maintain its original trim data even if the resulting images are otherwise the same.
@MrBrixican MrBrixican mentioned this issue Feb 10, 2024
Merged
@NoelFB
Copy link
Collaborator Author

NoelFB commented Feb 10, 2024

Should be resolved with #71

@NoelFB NoelFB closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoelFB