Item1819: undefined symbol: apreq_handle_apache2 when using mod_perl …

…> updated documentation; as documented I used perltidy on all *.pm files of ModPerlEngineContrib

git-svn-id: http://svn.foswiki.org/trunk/ModPerlEngineContrib@4569 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

data/System/ModPerlEngineContrib.txt

@@ -39,12 +39,20 @@ button and you'll get your config file.
 or else Apache will not start, reporting an error about missing
 lib/LocalSite.cfg %ENDCOLOR%
 
----+++ Foswiki configuration tunning
+In the web server configuraiton you will need to load mod_perl but also make sure to load the
+[[http://httpd.apache.org/apreq/][Apache HTTP Request Library]] (module apreq).
+If apreq is not loaded the following error may be encountered in certain situations e.g. during login:
+<verbatim>
+apache2: symbol lookup error: /usr/lib/perl5/auto/APR/Request/Apache2/Apache2.so: undefined symbol: apreq_handle_apache2
+</verbatim>
+
+---+++ Foswiki configuration tuning
 
 Fork new processes under =mod_perl= can be very slow, so some configuration
 changes are recommended.
 
-Access the [[%SCRIPTURL{"configure"}%][configure]] script and click the =Yes, I've read all the documentation= button.
+Access the [[%SCRIPTURL{"configure"}%][configure]] script and click the =Yes, I've read all the documentation=
+button to show the expert settings.
 Go to =Store Settings=:
    * ={StoreImpl}=: adjust to =RcsLite=
    * ={RCS}{SearchAlgorithm}=: use =Foswiki::Store::SearchAlgorithms::PurePerl= or Foswiki:Extensions/NativeSearchContrib

lib/Foswiki/Contrib/ModPerlEngineContrib.pm

@@ -23,8 +23,8 @@ use strict;
 
 use vars qw( $VERSION $RELEASE $SHORTDESCRIPTION );
 
-$VERSION = '$Rev$';
-$RELEASE = '0.9.1';
+$VERSION          = '$Rev$';
+$RELEASE          = '0.9.1';
 $SHORTDESCRIPTION = 'Permits Foswiki to be executed under mod_perl';
 
 1;

lib/Foswiki/Engine/Apache.pm

@@ -8,7 +8,7 @@
 # This module is based/inspired on Catalyst framework. Refer to
 #
 # http://search.cpan.org/perldoc?Catalyst
-# 
+#
 # for credits and liscence details.
 #
 # This program is free software; you can redistribute it and/or
@@ -66,7 +66,7 @@ BEGIN {
             $ENV{MOD_PERL_API_VERSION} = 1;
         }
     }
-    
+
     require Carp;
     $SIG{__DIE__} = \&Carp::confess;
 }
@@ -82,7 +82,7 @@ sub run {
     my $this = $Foswiki::engine;
     $this->{r} = shift;
     my $req = $this->prepare();
-    
+
     if ( UNIVERSAL::isa( $req, 'Foswiki::Request' ) ) {
         my $res = Foswiki::UI::handleRequest($req);
         $this->finalize( $res, $req );
@@ -113,9 +113,9 @@ sub prepareQueryParameters {
 sub prepareHeaders {
     my ( $this, $req ) = @_;
 
-    my %headers = %{$this->{r}->headers_in()};
-    while ( my ($header, $value) = each %headers ) {
-        $req->header($header => $value);
+    my %headers = %{ $this->{r}->headers_in() };
+    while ( my ( $header, $value ) = each %headers ) {
+        $req->header( $header => $value );
     }
     $req->remoteUser( $this->{r}->user );
     if ( $Foswiki::cfg{BehindProxy} ) {

lib/Foswiki/Engine/Apache/MP13.pm

@@ -8,7 +8,7 @@
 # This module is based/inspired on Catalyst framework. Refer to
 #
 # http://search.cpan.org/perldoc?Catalyst
-# 
+#
 # for credits and liscence details.
 #
 # This program is free software; you can redistribute it and/or

lib/Foswiki/Engine/Apache2.pm

@@ -8,7 +8,7 @@
 # This module is based/inspired on Catalyst framework. Refer to
 #
 # http://search.cpan.org/perldoc?Catalyst
-# 
+#
 # for credits and liscence details.
 #
 # This program is free software; you can redistribute it and/or
@@ -41,7 +41,7 @@ use base 'Foswiki::Engine::Apache';
 sub finalizeHeaders {
     my ( $this, @p ) = @_;
 
-    $this->SUPER::finalizeHeaders( @p );
+    $this->SUPER::finalizeHeaders(@p);
 
     # This handles the case where Apache2 will remove the Content-Length
     # header on a HEAD request.

lib/Foswiki/Engine/Apache2/MP20.pm

@@ -8,7 +8,7 @@
 # This module is based/inspired on Catalyst framework. Refer to
 #
 # http://search.cpan.org/perldoc?Catalyst
-# 
+#
 # for credits and liscence details.
 #
 # This program is free software; you can redistribute it and/or