Skip to content

Commit

Permalink
Item12481: added IE9 deprecation setting
Browse files Browse the repository at this point in the history
git-svn-id: http://svn.foswiki.org/trunk/NatSkinPlugin@16679 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
MichaelDaum authored and MichaelDaum committed Apr 30, 2013
1 parent 00926e0 commit e34146d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
4 changes: 2 additions & 2 deletions lib/Foswiki/Plugins/NatSkinPlugin.pm
Expand Up @@ -30,8 +30,8 @@ use Foswiki::Plugins::NatSkinPlugin::WebComponent ();
our $baseWeb;
our $baseTopic;

our $VERSION = '3.99_002';
our $RELEASE = '3.99_002';
our $VERSION = '3.99_003';
our $RELEASE = '3.99_003';
our $NO_PREFS_IN_TOPIC = 1;
our $SHORTDESCRIPTION = 'Support plugin for <nop>NatSkin';
our $themeEngine;
Expand Down
10 changes: 7 additions & 3 deletions lib/Foswiki/Plugins/NatSkinPlugin/Config.spec
Expand Up @@ -47,17 +47,21 @@ $Foswiki::cfg{NatSkin}{DetectExternalLinks} = 0;
$Foswiki::cfg{NatSkin}{XuaCompatible} = 'ie=edge,chrome=1';

# **BOOLEAN**
# Switch on to display a browser warning when an IE6 has been detected.
# Enable this switch to display a browser warning when an IE6 has been detected.
$Foswiki::cfg{NatSkin}{DeprecateIE6} = 1;

# **BOOLEAN**
# Switch on to display a browser warning when an IE7 has been detected. WARNING: an IE8 in compatibility mode will report
# Enable this switch to display a browser warning when an IE7 has been detected. WARNING: an IE8 in compatibility mode will report
# as an IE7 even though it has been forced back into IE8 standard mode using an appropriate X-UA-Compatible HTTP header.
$Foswiki::cfg{NatSkin}{DeprecateIE7} = 1;

# **BOOLEAN**
# Switch on to display a browser warning when an IE8 has been detected.
# Enable this switch to display a browser warning when an IE8 has been detected.
$Foswiki::cfg{NatSkin}{DeprecateIE8} = 1;

# **BOOLEAN**
# Enable this switch to display a browser warning when an IE9 has been detected.
$Foswiki::cfg{NatSkin}{DeprecateIE9} = 0;

1;

8 changes: 1 addition & 7 deletions lib/Foswiki/Plugins/NatSkinPlugin/ThemeEngine.pm
Expand Up @@ -403,13 +403,7 @@ sub init {
$context->{UnsupportedBrowser} = 1 if $context->{msie6} && $Foswiki::cfg{NatSkin}{DeprecateIE6};
$context->{UnsupportedBrowser} = 1 if $context->{msie7} && $Foswiki::cfg{NatSkin}{DeprecateIE7};
$context->{UnsupportedBrowser} = 1 if $context->{msie8} && $Foswiki::cfg{NatSkin}{DeprecateIE8};

# It would have been preferable to deprecate IE7 as well. However, in "compatibility mode" an IE8
# still reports as an IE7, even though we force it out of "compatibility mode" back into standard mode
# with an x-ua-compatible http header. So while a real IE7 isn't supported, an IE8 reporting as IE7 even
# though it renders in I8 mode, is fine. It seems though that we can't distinguish these two cases.
# Note that this only affects people still on Windows XP not being able to upgrade their browser to IE8 and
# are unlikely to upgrade all all of their windows operating system just to get IE9 or IE10.
$context->{UnsupportedBrowser} = 1 if $context->{msie9} && $Foswiki::cfg{NatSkin}{DeprecateIE9};
}

# SMELL: these misc helper contexts should be core
Expand Down

0 comments on commit e34146d

Please sign in to comment.