Item1898: update docs, and port to foswiki

git-svn-id: http://svn.foswiki.org/trunk/ValidateUrlsPlugin@4617 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

data/System/ValidateUrlsPlugin.txt

@@ -11,8 +11,8 @@ One line description, required for extensions repository catalog.
 
 This extension is best run from the command line, perhaps from a monthly cronjob..
 <verbatim>
-cd twiki/bin
-./rest ValidateUrlsPlugin.getExternalLinks web Sandbox
+cd foswiki/bin
+./rest /ValidateUrlsPlugin/getExternalLinks web=Sandbox
 </verbatim>
 This will generate or update =Sandbox.WebExternalURLsReport= for the Sandbox web, listing all the url's it finds in the topics of the Sandbox web, listed either as broken, or working (from the point of view of the server).
 
@@ -47,4 +47,4 @@ This can be changed by setting ={Plugins}{ValidateUrlsPlugin}{ReportViewPermissi
 |  Plugin Home: | http://foswiki.org/Extensions/ValidateUrlsPlugin |
 
 
-<!-- Do _not_ attempt to edit this topic; it is auto-generated. Please add comments/questions/remarks to the feedback topic on twiki.org instead. -->
+<!-- Do _not_ attempt to edit this topic; it is auto-generated. Please add comments/questions/remarks to the feedback topic on foswiki.org instead. -->

lib/Foswiki/Plugins/ValidateUrlsPlugin.pm

@@ -46,7 +46,6 @@ searches through the specified web and lists all the explicitly listed external
 =cut
 
 sub getExternalLinks {
-
     #my ($session) = @_;
 
 #TODO: make a lease file, and only allow the first request to run..
@@ -55,7 +54,9 @@ sub getExternalLinks {
     my %urlHash;
     my $urls = \%urlHash;
 
-    my $web = Foswiki::Func::getCgiQuery()->param('web');
+    my $query = Foswiki::Func::getRequestObject();
+    my $web = $query->param('web'); 
+    return 'no web specified' if (not defined($web));
     $web =~ /(.*)/;
     $web = $1;
 
@@ -102,7 +103,7 @@ s/($Foswiki::regex{linkProtocolPattern}:([^\s<>'"\]]+[^\s*.,!?;:"')<|\]]))/_exte
     my @okLinks;
 
     foreach my $key (@sortedKeys) {
-        if ( $urls->{$key}->{response} eq 200 ) {
+        if ( defined($urls->{$key}->{response}) and $urls->{$key}->{response} eq 200 ) {
             push( @okLinks, $key );
         }
         else {
@@ -161,7 +162,10 @@ s/($Foswiki::regex{linkProtocolPattern}:([^\s<>'"\]]+[^\s*.,!?;:"')<|\]]))/_exte
     return
         "$web contains "
       . scalar( keys( %{$urls} ) )
-      . " urls: <br />$return\n\n";
+      . " urls: <br />$return\n\n"
+      . "see <a href='"
+      . Foswiki::Func::getScriptUrl($web, 'WebExternalURLsReport', 'view')
+      . "'>$web 's WebExternalURLsReport</a>";
 }
 
 sub _externalLink {