Skip to content

Commit

Permalink
Item13313: because of the way the store caches TOPICINFO, there was a…
Browse files Browse the repository at this point in the history
… corner case where a reload of a topic could populate the TOPICINFO incorrectly. This is cured by calling getRevisionInfo - which is the approved way of accessing revision information. Direct access to TOPICINFO is faster, but can trip up.
  • Loading branch information
Comment committed Mar 23, 2015
1 parent 1d475d7 commit 09cd088
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions core/tools/change_store.pl
Expand Up @@ -259,6 +259,10 @@ sub validate_info {
# Reread the meta from the target store
switch_dirs(1);
$target_store->readTopic( $top_meta, $topic_version );

# Use getRevisionInfo to ensure the TOPICINFO is correct
# before we access it using 'find'
$top_meta->getRevisionInfo();
my $target_topicinfo = ( $top_meta->find('TOPICINFO') )[0];
my $target_info =
$target_store->getVersionInfo( $top_meta, $topic_version );
Expand Down

0 comments on commit 09cd088

Please sign in to comment.