Item14518: not supporting IE < 9 is okay too

foswiki · Dec 1, 2017 · 1446745 · 1446745
1 parent d4a4ab6
commit 1446745
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/JQueryVersionForOldIEs.pm b/JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/JQueryVersionForOldIEs.pm
@@ -13,11 +13,8 @@ sub check {
     my $e         = '';
     my $jqversion = $Foswiki::cfg{JQueryPlugin}{JQueryVersionForOldIEs};
 
-    if ( !$jqversion ) {
-        return $this->ERROR(<<'MESSAGE');
-There is no configured jQuery version
-MESSAGE
-    }
+    # not supporting browsers < IE9 is just fine
+    return '' if $jqversion eq '';
 
     if ( $jqversion =~ /^jquery-(\d+)\.(\d+)/ && defined $1
         and ( $1 * 1000 + $2 ) <= 1003 )

diff --git a/JQueryPlugin/lib/Foswiki/Plugins/JQueryPlugin/Config.spec b/JQueryPlugin/lib/Foswiki/Plugins/JQueryPlugin/Config.spec
@@ -38,8 +38,8 @@ $Foswiki::cfg{JQueryPlugin}{JQueryVersion} = 'jquery-2.2.4';
 # **SELECT , jquery-1.9.1, jquery-1.10.0, jquery-1.10.1, jquery-1.11.0, jquery-1.11.1, jquery-1.11.2, jquery-1.11.3, jquery-1.12.0, jquery-1.12.1, jquery-1.12.2, jquery-1.12.3, jquery-1.12.4**
 # Use a different jQuery library for Internet Explorer 6/7/8. Since jQuery-2.0 these old browsers aren't suppored anymore.
 # Use one of the jQuery-1.x libraries to still serve a compatible jQuery to these browsers. Or leave it empty to use the same 
-# library version for all browsers.
-$Foswiki::cfg{JQueryPlugin}{JQueryVersionForOldIEs} = 'jquery-1.12.4';
+# library version for all browsers. Leave it empty in case you don't need to support these old browsers anymore.
+$Foswiki::cfg{JQueryPlugin}{JQueryVersionForOldIEs} = '';
 
 # **SELECT ,base, flickr, foswiki, lightness, redmond, smoothness **
 $Foswiki::cfg{JQueryPlugin}{JQueryTheme} = 'foswiki';