Skip to content

Commit

Permalink
Item14237: Minor stylistic changes.
Browse files Browse the repository at this point in the history
  • Loading branch information
vrurg committed Apr 11, 2017
1 parent 20a5e51 commit 1a572d7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions core/lib/Foswiki/Config/Node.pm
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ my %types = (

# Resets only if leafState is undef. This will enforce re-check for the
# attribute.
sub _reset_leafState {
sub _recheck_leafState {
my $this = shift;
$this->clear_leafState
unless $this->has_leafState && defined $this->leafState;
Expand All @@ -188,7 +188,7 @@ sub setLeafState {
$this->leafState( $state ? LEAF : BRANCH );
}
else {
$this->_reset_leafState;
$this->_recheck_leafState;
}
}

Expand All @@ -202,7 +202,7 @@ Returns true if node is a leaf.

sub isLeaf {
my $this = shift;
$this->_reset_leafState;
$this->_recheck_leafState;
return defined $this->leafState && $this->leafState == LEAF;
}

Expand All @@ -216,7 +216,7 @@ Returns true if node is a branch.

sub isBranch {
my $this = shift;
$this->_reset_leafState;
$this->_recheck_leafState;
return defined $this->leafState && $this->leafState == BRANCH;
}

Expand Down Expand Up @@ -254,7 +254,7 @@ sub setOpt_type {
my ( $opt, $val ) = @_;

Foswiki::Exception::Config::BadSpecData->throw(
text => "Node type is not defined",
text => "Node type can not be undefined",
nodeObject => $this,
) unless defined $val;

Expand Down
4 changes: 2 additions & 2 deletions core/lib/Foswiki/Config/Spec/File.pm
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ pluggable parse => sub {
# We'd rather ignore any caching error. If specs cannot be
# cached then go away with it and recall the parser for every
# invocation.
# SMELL Replace warn with bufferizing messaging when it's ready.
warn "Cannot clone specs for caching: " . $e;
# SMELL Replace warn with bufferized messaging when it's ready.
warn "Cannot cache specs: " . $e;
};
}

Expand Down

0 comments on commit 1a572d7

Please sign in to comment.