Skip to content

Commit

Permalink
Item11690: do not double urlEncode param name, and urlDecode trace ou…
Browse files Browse the repository at this point in the history
…tput in Foswiki::Request::Cache to match appearance of input

git-svn-id: http://svn.foswiki.org/branches/Release01x01@14494 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
FlorianSchlichting authored and FlorianSchlichting committed Mar 28, 2012
1 parent 89adb41 commit 317c491
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions core/lib/Foswiki/Request.pm
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ sub header {
---++ ObjectMethod save( $fh )
Saves object state to filehandle. Object may be loaded latter
Saves object state to filehandle. Object may be loaded later
passing $fh to new constructor or by calling load().
=cut
Expand All @@ -579,10 +579,9 @@ sub save {
my ( $this, $fh ) = @_;
local ( $\, $, ) = ( '', '' );
foreach my $name ( $this->param ) {
my $key = Foswiki::urlEncode($name);
foreach my $value ( $this->param($name) ) {
$value = '' unless defined $value;
print $fh Foswiki::urlEncode($key), '=',
print $fh Foswiki::urlEncode($name), '=',
Foswiki::urlEncode($value), "\n";
}
}
Expand Down
2 changes: 1 addition & 1 deletion core/lib/Foswiki/Request/Cache.pm
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ sub load {
my $here = tell $F;
while ( my $l = <$F> ) {
last if $l =~ /^=/;
print STDERR "CACHE $uid< $l";
print STDERR "CACHE $uid< " . Foswiki::urlDecode($l);
}
seek( $F, $here, 0 );
}
Expand Down

0 comments on commit 317c491

Please sign in to comment.